add TODOs about further constification

zugz · zugz · commit bc8e0a898927 · 2018-12-01T17:06:18.000+01:00
diff --git a/toxcore/group.c b/toxcore/group.c
@@ -271,6 +271,7 @@ typedef enum Groupchat_Closest {
 
 static int add_to_closest(Group_Chats *g_c, uint32_t groupnumber, const uint8_t *real_pk, const uint8_t *temp_pk)
 {
+    // TODO(zugz): this can be const. Similarly throughout the file.
     Group_c *g = get_group_c(g_c, groupnumber);
 
     if (!g) {
diff --git a/toxcore/tox.c b/toxcore/tox.c
@@ -713,6 +713,7 @@ Tox_Connection tox_self_get_connection_status(const Tox *tox)
 {
     const Messenger *m = tox->m;
 
+    // TODO(zugz): this can be const. Similarly throughout the file.
     unsigned int ret = onion_connection_status(m->onion_c);
 
     if (ret == 2) {

Original file line number	Diff line number	Diff line change
`@@ -271,6 +271,7 @@ typedef enum Groupchat_Closest {`
`271`	`271`
`272`	`272`	`static int add_to_closest(Group_Chats g_c, uint32_t groupnumber, const uint8_t real_pk, const uint8_t *temp_pk)`
`273`	`273`	`{`
	`274`	`+ // TODO(zugz): this can be const. Similarly throughout the file.`
`274`	`275`	`Group_c *g = get_group_c(g_c, groupnumber);`
`275`	`276`
`276`	`277`	`if (!g) {`
Original file line number	Diff line number	Diff line change
`@@ -713,6 +713,7 @@ Tox_Connection tox_self_get_connection_status(const Tox *tox)`
`713`	`713`	`{`
`714`	`714`	`const Messenger *m = tox->m;`
`715`	`715`
	`716`	`+ // TODO(zugz): this can be const. Similarly throughout the file.`
`716`	`717`	`unsigned int ret = onion_connection_status(m->onion_c);`
`717`	`718`
`718`	`719`	`if (ret == 2) {`