Fix loop in SimpleDateTimeTextProvider (#202)

jodastephen · web-flow · commit d3fb4cd5bbba · 2025-03-11T00:01:57.000Z
Should continue the outer loop (based on the comment) Fixes #198
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,14 @@
   <body>
 
     <!-- types are add, fix, remove, update -->
+    <release version="1.7.1" date="SNAPSHOT" description="v1.7.1">
+      <action dev="jodastephen" type="fix" issue="198">
+        Fix implementation of `SimpleDateTimeTextProvider`.
+      </action>
+      <action dev="jodastephen" type="update">
+        Update to time-zone data 2025agtz.
+      </action>
+    </release>
     <release version="1.7.0" date="2024-09-17" description="v1.7.0">
       <action dev="jodastephen" type="fix">
         Enhance TZDB parsing, handling more shortened forms.
diff --git a/src/main/java/org/threeten/bp/format/SimpleDateTimeTextProvider.java b/src/main/java/org/threeten/bp/format/SimpleDateTimeTextProvider.java
@@ -426,11 +426,12 @@ static final class LocaleStore {
             this.valueTextMap = valueTextMap;
             Map<TextStyle, List<Entry<String, Long>>> map = new HashMap<TextStyle, List<Entry<String,Long>>>();
             List<Entry<String, Long>> allList = new ArrayList<Map.Entry<String,Long>>();
+            outer:
             for (TextStyle style : valueTextMap.keySet()) {
                 Map<String, Entry<String, Long>> reverse = new HashMap<String, Map.Entry<String,Long>>();
                 for (Map.Entry<Long, String> entry : valueTextMap.get(style).entrySet()) {
                     if (reverse.put(entry.getValue(), createEntry(entry.getValue(), entry.getKey())) != null) {
-                        continue;  // not parsable, try next style
+                        continue outer;  // not parsable, try next style
                     }
                 }
                 List<Entry<String, Long>> list = new ArrayList<Map.Entry<String,Long>>(reverse.values());

Original file line number	Diff line number	Diff line change
`@@ -426,11 +426,12 @@ static final class LocaleStore {`
`426`	`426`	`this.valueTextMap = valueTextMap;`
`427`	`427`	`Map<TextStyle, List<Entry<String, Long>>> map = new HashMap<TextStyle, List<Entry<String,Long>>>();`
`428`	`428`	`List<Entry<String, Long>> allList = new ArrayList<Map.Entry<String,Long>>();`
	`429`	`+ outer:`
`429`	`430`	`for (TextStyle style : valueTextMap.keySet()) {`
`430`	`431`	`Map<String, Entry<String, Long>> reverse = new HashMap<String, Map.Entry<String,Long>>();`
`431`	`432`	`for (Map.Entry<Long, String> entry : valueTextMap.get(style).entrySet()) {`
`432`	`433`	`if (reverse.put(entry.getValue(), createEntry(entry.getValue(), entry.getKey())) != null) {`
`433`		`- continue; // not parsable, try next style`
	`434`	`+ continue outer; // not parsable, try next style`
`434`	`435`	`}`
`435`	`436`	`}`
`436`	`437`	`List<Entry<String, Long>> list = new ArrayList<Map.Entry<String,Long>>(reverse.values());`