Merge pull request #1720 from nmarisi/fix-NSInternalInconsistencyException

CHaNGeTe · web-flow · commit f66ca32d499d · 2019-09-08T08:29:27.000+02:00
Removing the call to observeValueForKeyPath:ofObject:change:context: …
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## Changelog
 
+### Version 5.0.2
+* Fix crash when RCTVideo's superclass doesn't observe the keyPath 'frame' (iOS) [#1720](https://github.com/react-native-community/react-native-video/pull/1720)
+
 ### Version 5.0.1
 * Fix AndroidX Support bad merge
 
diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -712,8 +712,6 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
 
         return;
       }
-  } else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) {
-    [super observeValueForKeyPath:keyPath ofObject:object change:change context:context];
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -712,8 +712,6 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N`
`712`	`712`
`713`	`713`	`return;`
`714`	`714`	`}`
`715`		`- } else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) {`
`716`		`- [super observeValueForKeyPath:keyPath ofObject:object change:change context:context];`
`717`	`715`	`}`
`718`	`716`	`}`
`719`	`717`