Skip to content

Commit 9c1aa44

Browse files
committed
Remove explicit and implied references to specific MSRVs
After conversation in Twitter DM re: serde-rs#2255, it became clear that serde does not, in fact, have a specific MSRV policy, but rather strives to be buildable with older rustc as only a practical matter. This led to some confusion from users, as the `rust-version` Cargo.toml tag is often used to communicate a specific MSRV policy. Thus, this PR simply removes references which could be confused for a specific MSRV policy, leaving a comment in CI that the test with older rustc's does not imply a specific policy.
1 parent 3d02516 commit 9c1aa44

File tree

7 files changed

+3
-10
lines changed

7 files changed

+3
-10
lines changed

.github/workflows/ci.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ jobs:
6868
RUSTFLAGS: --cfg exhaustive ${{env.RUSTFLAGS}}
6969
if: matrix.os != 'windows'
7070

71-
msrv:
71+
backward_compat:
72+
# Note that this test does NOT imply a specific MSRV policy.
7273
name: Rust 1.13.0
7374
runs-on: ubuntu-latest
7475
steps:

README.md

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
1-
# Serde   [![Build Status]][actions] [![Latest Version]][crates.io] [![serde: rustc 1.13+]][Rust 1.13] [![serde_derive: rustc 1.31+]][Rust 1.31]
1+
# Serde   [![Build Status]][actions] [![Latest Version]][crates.io]
22

33
[Build Status]: https://img.shields.io/github/workflow/status/serde-rs/serde/CI/master
44
[actions]: https://github.com/serde-rs/serde/actions?query=branch%3Amaster
55
[Latest Version]: https://img.shields.io/crates/v/serde.svg
66
[crates.io]: https://crates.io/crates/serde
7-
[serde: rustc 1.13+]: https://img.shields.io/badge/serde-rustc_1.13+-lightgray.svg
87
[serde_derive: rustc 1.31+]: https://img.shields.io/badge/serde_derive-rustc_1.31+-lightgray.svg
9-
[Rust 1.13]: https://blog.rust-lang.org/2016/11/10/Rust-1.13.html
10-
[Rust 1.31]: https://blog.rust-lang.org/2018/12/06/Rust-1.31-and-rust-2018.html
118

129
**Serde is a framework for *ser*ializing and *de*serializing Rust data structures efficiently and generically.**
1310

serde/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ keywords = ["serde", "serialization", "no_std"]
1212
license = "MIT OR Apache-2.0"
1313
readme = "crates-io.md"
1414
repository = "https://github.com/serde-rs/serde"
15-
rust-version = "1.13"
1615

1716
[dependencies]
1817
serde_derive = { version = "=1.0.143", optional = true, path = "../serde_derive" }

serde_derive/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ keywords = ["serde", "serialization", "no_std", "derive"]
1111
license = "MIT OR Apache-2.0"
1212
readme = "crates-io.md"
1313
repository = "https://github.com/serde-rs/serde"
14-
rust-version = "1.31"
1514

1615
[features]
1716
default = []

serde_derive_internals/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ include = ["lib.rs", "src/**/*.rs", "LICENSE-APACHE", "LICENSE-MIT"]
99
keywords = ["serde", "serialization"]
1010
license = "MIT OR Apache-2.0"
1111
repository = "https://github.com/serde-rs/serde"
12-
rust-version = "1.31"
1312

1413
[lib]
1514
path = "lib.rs"

serde_test/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ keywords = ["serde", "serialization", "testing"]
1212
license = "MIT OR Apache-2.0"
1313
readme = "crates-io.md"
1414
repository = "https://github.com/serde-rs/serde"
15-
rust-version = "1.13"
1615

1716
[dependencies]
1817
serde = { version = "1.0.60", path = "../serde" }

test_suite/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ toolchain_find = "0.2"
2020
fnv = "1.0"
2121
macrotest = "=1.0.9"
2222
prettyplease = "=0.1.14"
23-
rustversion = "1.0"
2423
serde = { path = "../serde", features = ["rc", "derive"] }
2524
serde_derive = { path = "../serde_derive", features = ["deserialize_in_place"] }
2625
serde_test = { path = "../serde_test" }

0 commit comments

Comments
 (0)