Skip to content

when running for a PR, improve in-issue reporting #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
mockersf opened this issue Jan 27, 2025 · 0 comments
Open
3 tasks

when running for a PR, improve in-issue reporting #100

mockersf opened this issue Jan 27, 2025 · 0 comments

Comments

@mockersf
Copy link
Member

  • when triggering for a PR, add a nonce as metadata to every pixel eagle run
  • once done, call api https://pixel-eagle.com/B25A040A-A980-4602-B90C-D480AB84076D/runs\?filter=nonce={nonce}
  • for every run, there will be an entry of the form
  {
    "project_id": "b25a040a-a980-4602-b90c-d480ab84076d",
    "id": 7563,
    "timestamp": 1737953544,
    "metadata": {
      "os": "macOS",
      "branch": "PR-17413",
      "gitref": "6911ddfd4b2d0f9efa6adba1605736112f7ef4f4"
      "nonce": "{nonce}",
    },
    "screenshot_count": 266,
    "compared_with": {
      "id": 7560,
      "changed": 8,
      "missing": 0
    }
  }
  • the counts in compared_with are done with a 0% tolerance and may not be the actual ones
  • to get the actual result, call https://pixel-eagle.com/B25A040A-A980-4602-B90C-D480AB84076D/runs/{id}/compare/{compared_with.id}
  • add nonce
  • call the list run API and report for every run
  • if there are diffs, check the actual results of the run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant