Skip to content

Draft: adds expecto provider example #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ImaginaryDevelopment
Copy link
Contributor

@ImaginaryDevelopment ImaginaryDevelopment commented Feb 16, 2021

Proposed Changes

This is to add a simple Expecto provider as an FsLibLog example.
Resolves #17

Types of changes

What types of changes does your code introduce to FsLibLog?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

needs building and testing work still

@TheAngryByrd
Copy link
Owner

@ImaginaryDevelopment did you still want to work on finishing this or should we close this?

@ImaginaryDevelopment
Copy link
Contributor Author

ImaginaryDevelopment commented Nov 22, 2021 via email

Copy link
Contributor Author

@ImaginaryDevelopment ImaginaryDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing from this example was doing
ExpectoLogProvider() |> LogProvider.setLoggerProvider
and then figuring out where all you need to do that to have the .exe AND dotnet test both actually activate that before tests start running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expecto hooking provider and example
2 participants