fix: address review feedback

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

rich/spinner.py

@@ -1,4 +1,4 @@
-from typing import cast, List, Optional, TYPE_CHECKING
+from typing import cast, List, Optional, TYPE_CHECKING, Union
 
 from ._spinners import SPINNERS
 from .measure import Measurement
@@ -34,7 +34,9 @@ def __init__(
             spinner = SPINNERS[name]
         except KeyError:
             raise KeyError(f"no spinner called {name!r}")
-        self.text = Text.from_markup(text) if isinstance(text, str) else text
+        self.text: "Union[RenderableType, Text]" = (
+            Text.from_markup(text) if isinstance(text, str) else text
+        )
         self.frames = cast(List[str], spinner["frames"])[:]
         self.interval = cast(float, spinner["interval"])
         self.start_time: Optional[float] = None
@@ -79,8 +81,7 @@ def render(self, time: float) -> "RenderableType":
             self.speed = self._update_speed
             self._update_speed = 0.0
 
-        # This normally can't be str, unless someone assigned it later.
-        if not self.text:  # type: ignore[truthy-bool]
+        if not self.text:
             return frame
         elif isinstance(self.text, (str, Text)):
             return Text.assemble(frame, " ", self.text)