Faster array combine in fortunes

joanhey · joanhey · commit ef8653913b19 · 2021-01-20T13:59:15.000+01:00
diff --git a/frameworks/PHP/duckphp/app/Model/FortuneModel.php b/frameworks/PHP/duckphp/app/Model/FortuneModel.php
@@ -15,7 +15,7 @@ public function getFortunes()
     {
         $sql = 'SELECT id, message FROM fortune';
         $data = M::DB()->fetchAll($sql);
-        $ret = array_combine(array_column($data,'id'),array_column($data,'message'));
+        $ret = array_column($data, 'message', 'id');
         $ret[0] = 'Additional fortune added at request time.';
         asort($ret);
         return $ret;

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public function getFortunes()`
`15`	`15`	`{`
`16`	`16`	`$sql = 'SELECT id, message FROM fortune';`
`17`	`17`	`$data = M::DB()->fetchAll($sql);`
`18`		`- $ret = array_combine(array_column($data,'id'),array_column($data,'message'));`
	`18`	`+ $ret = array_column($data, 'message', 'id');`
`19`	`19`	`$ret[0] = 'Additional fortune added at request time.';`
`20`	`20`	`asort($ret);`
`21`	`21`	`return $ret;`