refactor(api): catch IndexOutOfBounds on getDimensionTypeID(int)

Author: ROMVoid95

src/main/java/micdoodle8/mods/galacticraft/api/GalacticraftRegistry.java

@@ -8,7 +8,6 @@
 package micdoodle8.mods.galacticraft.api;
 
 import com.google.common.collect.Lists;
-import java.lang.reflect.Method;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.LinkedList;
@@ -35,22 +34,21 @@
 public class GalacticraftRegistry
 {
 
-    private static Map<Class<? extends WorldProvider>, ITeleportType> teleportTypeMap = new HashMap<Class<? extends WorldProvider>, ITeleportType>();
-    private static List<SpaceStationType> spaceStations = new ArrayList<SpaceStationType>();
-    private static List<INasaWorkbenchRecipe> rocketBenchT1Recipes = new ArrayList<INasaWorkbenchRecipe>();
-    private static List<INasaWorkbenchRecipe> buggyBenchRecipes = new ArrayList<INasaWorkbenchRecipe>();
-    private static List<INasaWorkbenchRecipe> rocketBenchT2Recipes = new ArrayList<INasaWorkbenchRecipe>();
-    private static List<INasaWorkbenchRecipe> cargoRocketRecipes = new ArrayList<INasaWorkbenchRecipe>();
-    private static List<INasaWorkbenchRecipe> rocketBenchT3Recipes = new ArrayList<INasaWorkbenchRecipe>();
-    private static List<INasaWorkbenchRecipe> astroMinerRecipes = new ArrayList<INasaWorkbenchRecipe>();
-    private static Map<Class<? extends WorldProvider>, ResourceLocation> rocketGuiMap = new HashMap<Class<? extends WorldProvider>, ResourceLocation>();
-    private static Map<Integer, List<ItemStack>> dungeonLootMap = new HashMap<Integer, List<ItemStack>>();
-    private static List<Integer> dimensionTypeIDs = new ArrayList<Integer>();
-    private static List<IGameScreen> gameScreens = new ArrayList<IGameScreen>();
+    private static Map<Class<? extends WorldProvider>, ITeleportType> teleportTypeMap = new HashMap<>();
+    private static List<SpaceStationType> spaceStations = new ArrayList<>();
+    private static List<INasaWorkbenchRecipe> rocketBenchT1Recipes = new ArrayList<>();
+    private static List<INasaWorkbenchRecipe> buggyBenchRecipes = new ArrayList<>();
+    private static List<INasaWorkbenchRecipe> rocketBenchT2Recipes = new ArrayList<>();
+    private static List<INasaWorkbenchRecipe> cargoRocketRecipes = new ArrayList<>();
+    private static List<INasaWorkbenchRecipe> rocketBenchT3Recipes = new ArrayList<>();
+    private static List<INasaWorkbenchRecipe> astroMinerRecipes = new ArrayList<>();
+    private static Map<Class<? extends WorldProvider>, ResourceLocation> rocketGuiMap = new HashMap<>();
+    private static Map<Integer, List<ItemStack>> dungeonLootMap = new HashMap<>();
+    private static List<Integer> dimensionTypeIDs = new ArrayList<>();
+    private static List<IGameScreen> gameScreens = new ArrayList<>();
     private static int maxScreenTypes;
     private static Map<Integer, List<Object>> gearMap = new HashMap<>();
     private static Map<Integer, List<EnumExtendedInventorySlot>> gearSlotMap = new HashMap<>();
-    private static Method gratingRegister = null;
 
     /**
      * Register a new Teleport type for the world provider passed
@@ -101,7 +99,7 @@ public static void addDungeonLoot(int tier, ItemStack loot)
             dungeonStacks.add(loot);
         } else
         {
-            dungeonStacks = new ArrayList<ItemStack>();
+            dungeonStacks = new ArrayList<>();
             dungeonStacks.add(loot);
         }
 
@@ -311,7 +309,16 @@ public static DimensionType registerDimension(String name, String suffix, int id
 
     public static int getDimensionTypeID(int index)
     {
-        return GalacticraftRegistry.dimensionTypeIDs.get(index);
+        // Not the best solution but is better than the very unuseful IndexOutOfBoundsException message
+        try
+        {
+            return GalacticraftRegistry.dimensionTypeIDs.get(index);
+        } catch (IndexOutOfBoundsException e)
+        {
+            GalacticraftCore.logger.error("Attempted to get index[%d] while 'dimensionTypeIDs' size was %d", index, GalacticraftRegistry.dimensionTypeIDs.size());
+            return 0;
+        }
+
     }
 
     public static boolean isDimensionTypeIDRegistered(int typeId)