Skip to content

Commit 1e8c139

Browse files
authored
Merge pull request #361 from Team-WSS/fix/#360
[FIX] 피드 단건 조회 시 피드 작성자의 별점 반환
2 parents 95bfb8f + da222dc commit 1e8c139

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

src/main/java/org/websoso/WSSServer/dto/feed/FeedGetResponse.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import org.websoso.WSSServer.domain.Feed;
66
import org.websoso.WSSServer.domain.FeedImage;
77
import org.websoso.WSSServer.domain.Novel;
8-
import org.websoso.WSSServer.domain.User;
98
import org.websoso.WSSServer.domain.UserNovel;
109
import org.websoso.WSSServer.dto.user.UserBasicInfo;
1110

@@ -32,18 +31,18 @@ public record FeedGetResponse(
3231
String novelThumbnailImage,
3332
String novelGenre,
3433
String novelAuthor,
35-
Float userNovelRating,
34+
Float feedWriterNovelRating,
3635
String novelDescription
3736
) {
3837
public static FeedGetResponse of(Feed feed, UserBasicInfo feedUserBasicInfo, Novel novel, Boolean isLiked,
39-
List<String> relevantCategories, Boolean isMyFeed, User user) {
38+
List<String> relevantCategories, Boolean isMyFeed) {
4039
String title = null;
4140
Integer novelRatingCount = null;
4241
Float novelRating = null;
4342
String novelThumbnailImage = null;
4443
String novelGenre = null;
4544
String novelAuthor = null;
46-
Float userNovelRating = null;
45+
Float feedWriterNovelRating = null;
4746
String novelDescription = null;
4847

4948
if (novel != null) {
@@ -60,7 +59,7 @@ public static FeedGetResponse of(Feed feed, UserBasicInfo feedUserBasicInfo, Nov
6059
novelThumbnailImage = novel.getNovelImage();
6160
novelGenre = novel.getNovelGenres().get(0).getGenre().getGenreName();
6261
novelAuthor = novel.getAuthor();
63-
userNovelRating = getUserNovelRating(novel, user.getUserId());
62+
feedWriterNovelRating = getFeedWriterNovelRating(novel, feed.getUser().getUserId());
6463
novelDescription = novel.getNovelDescription();
6564
}
6665

@@ -91,7 +90,7 @@ public static FeedGetResponse of(Feed feed, UserBasicInfo feedUserBasicInfo, Nov
9190
novelThumbnailImage,
9291
novelGenre,
9392
novelAuthor,
94-
userNovelRating,
93+
feedWriterNovelRating,
9594
novelDescription
9695
);
9796
}
@@ -103,14 +102,14 @@ private static Float calculateNovelRating(Float novelRatingSum, Integer novelRat
103102
return Math.round((novelRatingSum / (float) novelRatingCount) * 10) / 10.0f;
104103
}
105104

106-
private static Float getUserNovelRating(Novel novel, Long visitorId) {
105+
private static Float getFeedWriterNovelRating(Novel novel, Long feedWriterId) {
107106
if (novel == null) {
108107
return null;
109108
}
110109

111110
return novel.getUserNovels()
112111
.stream()
113-
.filter(userNovel -> userNovel.getUser().getUserId().equals(visitorId))
112+
.filter(userNovel -> userNovel.getUser().getUserId().equals(feedWriterId))
114113
.findFirst()
115114
.map(UserNovel::getUserNovelRating)
116115
.orElse(null);

src/main/java/org/websoso/WSSServer/service/FeedService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public FeedGetResponse getFeedById(User user, Long feedId) {
248248
List<String> relevantCategories = feedCategoryService.getRelevantCategoryNames(feed.getFeedCategories());
249249
Boolean isMyFeed = isUserFeedOwner(feed.getUser(), user);
250250

251-
return FeedGetResponse.of(feed, feedUserBasicInfo, novel, isLiked, relevantCategories, isMyFeed, user);
251+
return FeedGetResponse.of(feed, feedUserBasicInfo, novel, isLiked, relevantCategories, isMyFeed);
252252
}
253253

254254
@Transactional(readOnly = true)

0 commit comments

Comments
 (0)