refactor: 하드코딩된 변수 상수화

Author: junseo511

app/src/main/java/com/into/websoso/core/common/util/DynamicLimitPhotoPicker.kt

@@ -41,28 +41,22 @@ class DynamicLimitPhotoPicker : ActivityResultContract<Input, List<Uri>>() {
     override fun createIntent(
         context: Context,
         input: Input,
-    ): Intent {
-        val mimeType = "image/*"
-        val intent: Intent
-
+    ): Intent =
         if (Build.VERSION.SDK_INT >= 33) {
-            intent = Intent(MediaStore.ACTION_PICK_IMAGES).apply {
-                type = mimeType
+            Intent(MediaStore.ACTION_PICK_IMAGES).apply {
+                type = MINE_TYPE
                 putExtra(MediaStore.EXTRA_PICK_IMAGES_MAX, input.maxSelectable)
             }
         } else {
-            intent = Intent(Intent.ACTION_OPEN_DOCUMENT).apply {
-                type = mimeType
+            Intent(Intent.ACTION_OPEN_DOCUMENT).apply {
+                type = MINE_TYPE
                 addCategory(Intent.CATEGORY_OPENABLE)
                 addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION)
                 addFlags(Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION)
                 putExtra(Intent.EXTRA_ALLOW_MULTIPLE, true)
             }
         }
 
-        return intent
-    }
-
     override fun parseResult(
         resultCode: Int,
         intent: Intent?,
@@ -81,4 +75,8 @@ class DynamicLimitPhotoPicker : ActivityResultContract<Input, List<Uri>>() {
 
         return uris
     }
+
+    companion object {
+        private const val MINE_TYPE: String = "image/*"
+    }
 }

app/src/main/java/com/into/websoso/ui/createFeed/CreateFeedViewModel.kt

@@ -284,7 +284,7 @@ class CreateFeedViewModel
             newImages: List<Uri>,
             retryCount: Int = 0,
         ) {
-            if (retryCount > 3) return
+            if (retryCount > MAX_RETRY_COUNT) return
 
             viewModelScope.launch {
                 runCatching {
@@ -304,26 +304,8 @@ class CreateFeedViewModel
             _attachedImages.value = currentImages
         }
 
-        private fun downloadImage(
-            url: String,
-            retryCount: Int = 0,
-        ) {
-            if (retryCount > 3) return
-
-            viewModelScope.launch {
-                runCatching {
-                    feedRepository.downloadImage(url)
-                }.onSuccess { uri ->
-                    uri.getOrNull()?.let {
-                        addCompressedImage(it)
-                    }
-                }.onFailure {
-                    downloadImage(url, retryCount + 1)
-                }
-            }
-        }
-
         companion object {
-            const val MAX_IMAGE_COUNT = 5
+            const val MAX_IMAGE_COUNT: Int = 5
+            private const val MAX_RETRY_COUNT: Int = 3
         }
     }