[!!!][TASK] Remove registered 'class' handling in abstract form VH

Do not handle manually registered 'class' attribute in
setErrorClassAttribute() anymore.

Resolves: #105485
Related: #105377
Related: #104412
Releases: main
Change-Id: Id688b797b2342daa950eaa4aa4a44d5b152020a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86801
Reviewed-by: Garvin Hicking <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Tested-by: core-ci <[email protected]>
Tested-by: Anja Leichsenring <[email protected]>
Reviewed-by: Anja Leichsenring <[email protected]>
Reviewed-by: Nikita Hovratov <[email protected]>
Tested-by: Nikita Hovratov <[email protected]>

Author: lolli42

typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105377-DeprecatedFunctionalityRemoved.rst

@@ -236,6 +236,9 @@ The following fallbacks have been removed:
 - Allowing instantiation of :php:`\TYPO3\CMS\Core\Imaging\IconRegistry` in ext_localconf.php
 - Accepting a comma-separated list of fields as value for the `columnsOnly` parameter
 - Support for extbase repository magic :php:`findByX()`, :php:`findOneByX()` and :php:`countByX()` methods
+- Fluid view helpers that extend :php:`\TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFieldViewHelper`
+  should no longer register :html:`class` attribute and should rely on attribute auto registration
+  for the error class to be added correctly.
 
 The following upgrade wizards have been removed:
 

typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php

@@ -325,12 +325,7 @@ protected function isObjectAccessorMode(): bool
      */
     protected function setErrorClassAttribute(): void
     {
-        if ($this->hasArgument('class')) {
-            // @deprecated: Fallback layer for VH's that register 'class' as argument
-            //              via registerUniversalTagAttributes(). Remove in v14. Make
-            //              elseif() below if().
-            $cssClass = $this->arguments['class'] . ' ';
-        } elseif (isset($this->additionalArguments['class'])) {
+        if (isset($this->additionalArguments['class'])) {
             $cssClass = $this->additionalArguments['class'] . ' ';
         } else {
             $cssClass = '';