[BUGFIX] Ensure proper test setup related to doctrine/dbal

With doctrine/dbal v3.5.0 some changes has been introduced which
shows invalid test setup. This change use proper test setup to be
okay again, if doctrine/dbal v3.5.0 is used.

See: doctrine/dbal#5770

Used command(s):

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #98704
Releases: main
Change-Id: I936e5cd291086020e60be418176b0f294fb43a45
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76231
Tested-by: core-ci <[email protected]>
Tested-by: Christian Kuhn <[email protected]>
Tested-by: Andreas Fernandez <[email protected]>
Tested-by: Stefan Bürk <[email protected]>
Reviewed-by: Christian Kuhn <[email protected]>
Reviewed-by: Andreas Fernandez <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>

Author: sbuerk

Build/phpstan/phpstan-baseline.neon

@@ -1545,11 +1545,6 @@ parameters:
 			count: 1
 			path: ../../typo3/sysext/core/Tests/Unit/Database/RelationHandlerTest.php
 
-		-
-			message: "#^Parameter \\#1 \\$newTables of class Doctrine\\\\DBAL\\\\Schema\\\\SchemaDiff constructor expects array\\<Doctrine\\\\DBAL\\\\Schema\\\\Table\\>, null given\\.$#"
-			count: 1
-			path: ../../typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php
-
 		-
 			message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 0 and string\\|null will always evaluate to false\\.$#"
 			count: 1

typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php

@@ -28,7 +28,6 @@
 use TYPO3\CMS\Core\Database\Connection;
 use TYPO3\CMS\Core\Database\Platform\PlatformInformation;
 use TYPO3\CMS\Core\Database\Schema\ConnectionMigrator;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 /**
@@ -73,7 +72,7 @@ protected function setUp(): void
      */
     public function tableNamesStickToTheMaximumCharactersWhenPrefixedForRemoval(): void
     {
-        $originalSchemaDiff = GeneralUtility::makeInstance(SchemaDiff::class, null, null, [$this->getTable()]);
+        $originalSchemaDiff = new SchemaDiff([], [], [$this->getTable()]);
         $renamedSchemaDiff = $this->subject->_call('migrateUnprefixedRemovedTablesToRenames', $originalSchemaDiff);
 
         self::assertStringStartsWith('zzz_deleted_', $renamedSchemaDiff->changedTables[0]->newName);
@@ -89,9 +88,8 @@ public function tableNamesStickToTheMaximumCharactersWhenPrefixedForRemoval(): v
     public function columnNamesStickToTheMaximumCharactersWhenPrefixedForRemoval(): void
     {
         $table = $this->getTable();
-        $tableDiff = new TableDiff($table->getName());
-        $originalSchemaDiff = new SchemaDiff(null, [$tableDiff]);
-        $originalSchemaDiff->changedTables[0]->removedColumns[] = $this->getColumn();
+        $tableDiff = new TableDiff($table->getName(), [], [], [$this->getColumn()]);
+        $originalSchemaDiff = new SchemaDiff([], [$tableDiff]);
         $renamedSchemaDiff = $this->subject->_call('migrateUnprefixedRemovedFieldsToRenames', $originalSchemaDiff);
 
         self::assertStringStartsWith(