Unrelated: Optimize performance of SourceCodeLocation

Once again surprising, but for sufficiently many classes it has a noticeable performance impact to use `String.format(..)` instead of `StringBuilder` (which constant string concatenation will be compiled to in the byte code for all non-ancient JDK versions I know). Since we create the formatted source code location for every class in the import this scales linear with the number of classes.

Signed-off-by: Peter Gafert <[email protected]>

Author: codecholeric

archunit/src/main/java/com/tngtech/archunit/core/domain/SourceCodeLocation.java

@@ -40,7 +40,6 @@
  */
 @PublicAPI(usage = ACCESS)
 public final class SourceCodeLocation {
-    private static final String LOCATION_TEMPLATE = "(%s:%d)";
 
     @PublicAPI(usage = ACCESS)
     public static SourceCodeLocation of(JavaClass sourceClass) {
@@ -57,7 +56,7 @@ private static String formatLocation(JavaClass sourceClass, int lineNumber) {
                 ? sourceClass.getSource().get().getFileName()
                 : Optional.<String>absent();
         String sourceFileName = recordedSourceFileName.isPresent() ? recordedSourceFileName.get() : guessSourceFileName(sourceClass);
-        return String.format(LOCATION_TEMPLATE, sourceFileName, lineNumber);
+        return "(" + sourceFileName + ":" + lineNumber + ")";
     }
 
     private static String guessSourceFileName(JavaClass location) {