fix: refine codes

Author: halajohn

.vscode/launch.json

@@ -137,7 +137,7 @@
       "request": "launch",
       "program": "${workspaceFolder}/out/linux/x64/tests/standalone/ten_runtime_smoke_test",
       "args": [
-        "--gtest_filter=BasicTest.ThrowExceptionInExtension"
+        "--gtest_filter=BasicTest.EmptyExtensionGroup"
       ],
       "cwd": "${workspaceFolder}/out/linux/x64/tests/standalone/",
       "env": {

core/include_internal/ten_utils/log/termcolor.h

@@ -16,3 +16,4 @@
 #define TEN_LOG_COLOR_MAGENTA "\033[35m"
 #define TEN_LOG_COLOR_CYAN "\033[36m"
 #define TEN_LOG_COLOR_WHITE "\033[37m"
+#define TEN_LOG_COLOR_GOLD "\033[1;33m"

core/src/ten_runtime/extension/internal/close.c

@@ -94,8 +94,8 @@ static void ten_extension_do_close(ten_extension_t *self) {
              "Should not happen.");
 
   ten_extension_thread_t *extension_thread = self->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   ten_extension_on_deinit(self);

core/src/ten_runtime/extension/internal/path_timer.c

@@ -118,8 +118,8 @@ ten_timer_t *ten_extension_create_timer_for_in_path(ten_extension_t *self) {
              "Should not happen.");
 
   ten_extension_thread_t *extension_thread = self->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   ten_timer_t *timer = ten_timer_create(
@@ -138,8 +138,8 @@ ten_timer_t *ten_extension_create_timer_for_out_path(ten_extension_t *self) {
              "Should not happen.");
 
   ten_extension_thread_t *extension_thread = self->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   ten_timer_t *timer = ten_timer_create(

core/src/ten_runtime/extension/ten_env/on_xxx.c

@@ -97,8 +97,8 @@ bool ten_extension_on_configure_done(ten_env_t *self) {
   extension->state = TEN_EXTENSION_STATE_ON_CONFIGURE_DONE;
 
   ten_extension_thread_t *extension_thread = extension->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   if (extension_thread->is_close_triggered) {
@@ -249,8 +249,8 @@ bool ten_extension_on_init_done(ten_env_t *self) {
   extension->state = TEN_EXTENSION_STATE_ON_INIT_DONE;
 
   ten_extension_thread_t *extension_thread = extension->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   if (extension_thread->is_close_triggered) {
@@ -308,8 +308,8 @@ bool ten_extension_on_start_done(ten_env_t *self) {
   extension->state = TEN_EXTENSION_STATE_ON_START_DONE;
 
   ten_extension_thread_t *extension_thread = extension->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   if (extension_thread->is_close_triggered) {

core/src/ten_runtime/extension_context/extension_context.c

@@ -7,6 +7,7 @@
 #include "include_internal/ten_runtime/extension_context/extension_context.h"
 
 #include <stddef.h>
+#include <stdio.h>
 #include <stdlib.h>
 
 #include "include_internal/ten_runtime/addon/addon.h"
@@ -336,7 +337,19 @@ static void ten_extension_context_log_graph_resources(
   TEN_ASSERT(ten_extension_context_check_integrity(self, true),
              "Invalid use of extension_context %p.", self);
 
-  TEN_LOGM("[graph resources] %s, ", ten_engine_get_id(self->engine, true));
+  // Get the required information.
+  const char *app_uri = ten_app_get_uri(self->engine->app);
+  const char *graph_id = ten_engine_get_id(self->engine, true);
+  const char *graph_name = ten_string_get_raw_str(&self->engine->graph_name);
+
+  // Log the complete JSON in a single call.
+  TEN_LOGM(
+      "[graph resources] {"
+      "\"app_uri\": \"%s\", "
+      "\"graph name\": \"%s\", "
+      "\"graph id\": \"%s\" "
+      "}",
+      app_uri, graph_name, graph_id);
 }
 
 static void ten_extension_context_create_extension_group_done(

core/src/ten_runtime/extension_group/ten_env/on_xxx.c

@@ -78,8 +78,8 @@ void ten_extension_group_on_init_done(ten_env_t *self) {
            ten_extension_group_get_name(extension_group, true));
 
   ten_extension_thread_t *extension_thread = extension_group->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   int rc = ten_runloop_post_task_tail(
@@ -131,8 +131,8 @@ bool ten_extension_group_on_deinit_done(ten_env_t *self) {
   }
 
   ten_extension_thread_t *extension_thread = extension_group->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   // All extensions belong to this extension thread (group) are deleted, notify
@@ -160,8 +160,8 @@ void ten_extension_group_on_create_extensions_done(ten_extension_group_t *self,
            ten_string_get_raw_str(&self->name));
 
   ten_extension_thread_t *extension_thread = self->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   // Remove the extensions that were not successfully created from the list of
@@ -212,8 +212,8 @@ void ten_extension_group_on_destroy_extensions_done(
            ten_string_get_raw_str(&self->name));
 
   ten_extension_thread_t *extension_thread = self->extension_thread;
-  TEN_ASSERT(extension_thread &&
-                 ten_extension_thread_check_integrity(extension_thread, true),
+  TEN_ASSERT(extension_thread, "Should not happen.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(extension_thread, true),
              "Should not happen.");
 
   int rc = ten_runloop_post_task_tail(

core/src/ten_runtime/extension_thread/extension_thread.c

@@ -26,6 +26,7 @@
 #include "include_internal/ten_runtime/extension_thread/msg_interface/common.h"
 #include "include_internal/ten_runtime/msg/msg.h"
 #include "include_internal/ten_runtime/ten_env/ten_env.h"
+#include "include_internal/ten_utils/log/log.h"
 #include "include_internal/ten_utils/sanitizer/thread_check.h"
 #include "ten_runtime/extension/extension.h"
 #include "ten_runtime/ten_env/ten_env.h"
@@ -493,6 +494,65 @@ void ten_extension_thread_start_life_cycle_of_all_extensions_task(
   }
 }
 
+static void ten_extension_thread_log_graph_resources(
+    ten_extension_thread_t *self) {
+  TEN_ASSERT(self, "Invalid argument.");
+  TEN_ASSERT(ten_extension_thread_check_integrity(self, true),
+             "Invalid use of extension_thread %p.", self);
+
+  // Get the required information.
+  const char *app_uri = ten_app_get_uri(self->extension_context->engine->app);
+  const char *graph_id =
+      ten_engine_get_id(self->extension_context->engine, false);
+  const char *graph_name =
+      ten_string_get_raw_str(&self->extension_context->engine->graph_name);
+
+  // Build extension list entries.
+  ten_string_t extensions_json;
+  ten_string_init(&extensions_json);
+
+  bool first_extension = true;
+
+  ten_list_foreach (&self->extensions, iter) {
+    ten_extension_t *extension = ten_ptr_listnode_get(iter.node);
+    TEN_ASSERT(extension, "Should not happen.");
+    TEN_ASSERT(ten_extension_check_integrity(extension, true),
+               "Invalid use of extension %p.", extension);
+
+    // Add comma for all but the first extension.
+    if (!first_extension) {
+      ten_string_append_formatted(&extensions_json, "%s", ", ");
+    }
+    first_extension = false;
+
+    // Add extension entry with thread_id.
+    char entry[256];
+    int written =
+        snprintf(entry, sizeof(entry), "\"%s\": {\"thread_id\": %lld}",
+                 ten_extension_get_name(extension, true), (long long)self->tid);
+
+    if (written < 0 || written >= (int)sizeof(entry)) {
+      TEN_LOGE("Error formatting extension entry or buffer too small");
+      continue;
+    }
+
+    ten_string_append_formatted(&extensions_json, "%s", entry);
+  }
+
+  // Log the complete JSON in a single call.
+  TEN_LOGM(
+      "[graph resources] {"
+      "\"app_uri\": \"%s\", "
+      "\"graph name\": \"%s\", "
+      "\"graph id\": \"%s\", "
+      "\"extensions\": {%s}"
+      "}",
+      app_uri, graph_name, graph_id, ten_string_get_raw_str(&extensions_json));
+
+  // Clean up.
+  ten_string_deinit(&extensions_json);
+}
+
 void ten_extension_thread_add_all_created_extensions(
     ten_extension_thread_t *self) {
   TEN_ASSERT(self, "Invalid argument.");
@@ -501,16 +561,14 @@ void ten_extension_thread_add_all_created_extensions(
 
   ten_extension_context_t *extension_context = self->extension_context;
   TEN_ASSERT(extension_context, "Should not happen.");
-  TEN_ASSERT(
-      // TEN_NOLINTNEXTLINE(thread-check)
-      // thread-check: We are in the extension thread, and throughout the entire
-      // lifecycle of the extension, the extension_context where the extension
-      // resides remains unchanged. Even in the closing flow, the
-      // extension_context is closed later than the extension itself. Therefore,
-      // using a pointer to the extension_context within the extension thread is
-      // thread-safe.
-      ten_extension_context_check_integrity(extension_context, false),
-      "Should not happen.");
+  // TEN_NOLINTNEXTLINE(thread-check)
+  // thread-check: We are in the extension thread, and throughout the entire
+  // lifecycle of the extension, the extension_context where the extension
+  // resides remains unchanged. Even in the closing flow, the extension_context
+  // is closed later than the extension itself. Therefore, using a pointer to
+  // the extension_context within the extension thread is thread-safe.
+  TEN_ASSERT(ten_extension_context_check_integrity(extension_context, false),
+             "Should not happen.");
 
   ten_list_foreach (&self->extensions, iter) {
     ten_extension_t *extension = ten_ptr_listnode_get(iter.node);
@@ -525,6 +583,8 @@ void ten_extension_thread_add_all_created_extensions(
     ten_extension_thread_add_extension(self, extension);
   }
 
+  ten_extension_thread_log_graph_resources(self);
+
   // Notify the engine to handle those newly created extensions.
 
   ten_engine_t *engine = extension_context->engine;

core/src/ten_utils/log/formatter.c

@@ -113,6 +113,9 @@ void ten_log_colored_formatter(ten_string_t *buf, TEN_LOG_LEVEL level,
   // Determine color based on log level.
   const char *level_color = NULL;
   switch (level) {
+  case TEN_LOG_LEVEL_MANDATORY:
+    level_color = TEN_LOG_COLOR_GOLD;
+    break;
   case TEN_LOG_LEVEL_FATAL:
   case TEN_LOG_LEVEL_ERROR:
     level_color = TEN_LOG_COLOR_RED;