Downloader dedup #4287
Open
Downloader dedup #4287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morilli
reviewed
Apr 14, 2025
| if (OSTailoredCode.IsUnixHost) | ||
| { | ||
| OSTailoredCode.ConstructSubshell("chmod", $"+x {DownloadTo}", checkStdout: false).Start(); | ||
| Thread.Sleep(50); // Linux I/O flush idk |
There was a problem hiding this comment.
I realize this is mostly copy-pasted code but shouldn't this idelly be Process.WaitForExit() instead of an arbitrary sleep?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does enough for #4275 that I'd be comfortable putting out a release with it.
I've done some testing of the FFmpeg one on NixOS, but it needs more testing.