Additional rubocop formatting

Author: Syntaf

app/controllers/watched_area_controller.rb

@@ -34,7 +34,7 @@ def climbing_area
                                    .first
 
     respond_to do |format|
-      format.json {
+      format.json do
         render :json => @rainy_day_area,
                :include => {
                  :climbing_area => {
@@ -47,7 +47,7 @@ def climbing_area
                  }
                },
                :except => %i[created_at updated_at id]
-      }
+      end
     end
   end
 

app/helpers/material_forms_helper.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Rails/HelperInstanceVariable
 module MaterialFormsHelper
   class MaterialFormBuilder < ActionView::Helpers::FormBuilder
     def validation_message(attribute)
@@ -11,17 +12,17 @@ def validation_message(attribute)
       )
     end
 
-    def text_field(attribute, options={})
+    def text_field(attribute, options = {})
       options = append_material_class(options)
       super
     end
 
-    def email_field(attribute, options={})
+    def email_field(attribute, options = {})
       options = append_material_class(options)
       super
     end
 
-    def telephone_field(attribute, options={})
+    def telephone_field(attribute, options = {})
       options = append_material_class(options)
       super
     end
@@ -37,7 +38,7 @@ def select(attribute, choices = nil, options = {},
       super
     end
 
-    def submit(value=nil, options={})
+    def submit(value = nil, options = {})
       options = append_material_class(options, 'btn btn-primary')
       super
     end
@@ -53,3 +54,5 @@ def append_material_class(options = {}, html_class = 'form-control')
     end
   end
 end
+
+# rubocop:enable Rails/HelperInstanceVariable

app/mailers/admin_mailer.rb

@@ -1,11 +1,15 @@
 # frozen_string_literal: true
 
 class AdminMailer < Devise::Mailer
-    default from: '[email protected]'
-    layout 'mailer'
+  default from: '[email protected]'
+  layout 'mailer'
 
-    def new_user_waiting_for_approval(email)
-        @email = email
-        mail(to: '[email protected]', subject: 'New User Awaiting Admin Approval')
-    end
+  def new_user_waiting_for_approval(email)
+    @email = email
+
+    mail(
+      to: '[email protected]',
+      subject: 'New User Awaiting Admin Approval'
+    )
+  end
 end

app/models/climbing_area.rb

@@ -1,9 +1,12 @@
 # frozen_string_literal: true
 
 class ClimbingArea < ApplicationRecord
-  has_many :rainy_day_areas
+  has_many :rainy_day_areas, dependent: :destroy
   has_many :watched_areas, through: :rainy_day_areas
-  has_one :location, :inverse_of => :climbing_area, required: true
+  has_one :location,
+          inverse_of: :climbing_area,
+          dependent: :destroy,
+          required: true
 
   accepts_nested_attributes_for :location
 

app/models/local_climbing_org.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class LocalClimbingOrg < ApplicationRecord
-  has_many :watched_areas
+  has_many :watched_areas, dependent: :nullify
 end

app/models/watched_area.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WatchedArea < ApplicationRecord
-  has_many :rainy_day_areas
+  has_many :rainy_day_areas, dependent: :destroy
   has_many :climbing_areas, through: :rainy_day_areas
 
   belongs_to :local_climbing_org

rails.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The following comments fill some of the gaps in Solargraph's understanding of
 # Rails apps. Since they're all in YARD, they get mapped in Solargraph but
 # ignored at runtime.

test/controllers/castlerock_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class CastlerockControllerTest < ActionDispatch::IntegrationTest

test/controllers/redrock_controller_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 class RedrockControllerTest < ActionDispatch::IntegrationTest
-  test "should get index" do
+  test 'should get index' do
     get redrock_index_url
     assert_response :success
   end

test/mailers/admin_mailer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class AdminMailerTest < ActionMailer::TestCase

test/mailers/membership_mailer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MembershipMailerTest < ActionMailer::TestCase

test/mailers/previews/admin_mailer_preview.rb

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
+
 # Preview all emails at http://localhost:3000/rails/mailers/admin_mailer
 class AdminMailerPreview < ActionMailer::Preview
-
 end

test/mailers/previews/membership_mailer_preview.rb

@@ -3,7 +3,8 @@
 # Preview all emails at http://localhost:3000/rails/mailers/membership_mailer
 class MembershipMailerPreview < ActionMailer::Preview
   def new_membership_email
-    MembershipMailer.with(application: JointMembershipApplication.where(paid_cash: false).first)
-                    .signup_confirmation
+    MembershipMailer.with(
+      application: JointMembershipApplication.where(paid_cash: false).first
+    ).signup_confirmation
   end
 end

test/models/climbing_area_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class ClimbingAreaTest < ActiveSupport::TestCase

test/models/local_climbing_org_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class LocalClimbingOrgTest < ActiveSupport::TestCase

test/models/location_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class LocationTest < ActiveSupport::TestCase

test/models/rainy_day_area_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class RainyDayAreaTest < ActiveSupport::TestCase

test/models/user_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class UserTest < ActiveSupport::TestCase

test/models/watched_area_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class WatchedAreaTest < ActiveSupport::TestCase