Skip to content

Make minimum volume capacity configurable #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hotpheex opened this issue Jan 16, 2024 · 1 comment
Open

Make minimum volume capacity configurable #78

hotpheex opened this issue Jan 16, 2024 · 1 comment

Comments

@hotpheex
Copy link

I'm getting this error when requesting a volume <1Gi:
GRPC error: rpc error: code = InvalidArgument desc = Invalid input: required bytes is smaller than 1G

From what I can tell this is defaulting to a 1Gi minimum size if a custom range is not provided, but I cannot see a way for a user to configure the value. Is a 1Gi minimum volume size a limitation of Synology or is it possible to just add another flag to override it? Happy to raise a PR if its just a case of passing in a new value.

if capRange == nil {
return 1 * utils.UNIT_GB, nil
}

@chihyuwu
Copy link
Collaborator

hi @hotpheex,
Yes, the 1Gi minimum size is a limitation of Synology LUNs, as specified in the documentation.

In Synology DSM, the minimum size for a LUN is 1GB(Gi), and the minimum quota for a shared folder is 1MB(Mi).
In the current implementation of synology-csi, we have standardized the minimum volume size to 1GB.
Perhaps a better approach would be allowing file protocols, such as SMB and NFS, to set the size smaller than 1Gi (but at least 1Mi).

Certainly appreciate your raising a PR! The earlier suggestion is something you might consider. Thank you in advance for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants