Skip to content

Missing examples and documentation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ziotom78 opened this issue Oct 16, 2019 · 5 comments
Closed

Missing examples and documentation #2

ziotom78 opened this issue Oct 16, 2019 · 5 comments

Comments

@ziotom78
Copy link

The only documentation for the library seems to be in tests. Ideally, one would expect a short example to be included in the README. A nice example is the following package, which has been positively reviewed by JOSS referees:

https://github.com/GeoStat-Framework/pentapy
@ziotom78
Copy link
Author

Another missing point is some API documentation. This should include a list of functions, grouped by category, a list of arguments, the return value, and a description of their purpose.

Today, Python packages are usually documented using Sphinx, and the documentation is hosted either on ReadTheDocs or GitHub pages. You can refer to pentapy again:

https://geostat-framework.readthedocs.io/projects/pentapy/en/latest/

@ziotom78
Copy link
Author

This refers to JOSS' review («Functionality documentation», openjournals/joss-reviews#1809).

@SuperKam91
Copy link
Owner

Thank you again @ziotom78 for your advice. I have taken your comments on board and created a read the docs site for gns: https://geometric-nested-sampling.readthedocs.io/en/latest/.

It's a little rough round the edges, but hopefully it will suffice for now and I will refine it over time as I learn how to use sphinx better. Note the main sub-modules which would be used by the end user, i.e. nested_run.py, plotting.py, output.py and theoretical_funcs.py have been documented the most.

I have included a minimum working example in both the README and the read the docs pages.

@ziotom78
Copy link
Author

Excellent! However, the documentation refers to file PACKAGEAPI.md for the full documentation of the API, yet this file does not exist in the repository. Did you forget to add it to the commit?

@SuperKam91
Copy link
Owner

@ziotom78 good spot. I have rectified this typo, the API documentation should now be live: https://geometric-nested-sampling.readthedocs.io/en/latest/index.html. As I said above, may need tidying up in a few places but hopefully will be sufficient in its current form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants