STYLE: Declare wanted parameter of CheckNumberOfSamples SizeValueType

N-Dekker · N-Dekker · commit cbb8efeb76fc · 2025-03-24T23:34:25.000+01:00
The use of `unsigned long` as parameter type might cause narrowing type
conversions, especially on Windows, for which `unsigned long` is only 32-bit.
diff --git a/Common/CostFunctions/itkAdvancedImageToImageMetric.h b/Common/CostFunctions/itkAdvancedImageToImageMetric.h
@@ -483,7 +483,7 @@ class ITK_TEMPLATE_EXPORT AdvancedImageToImageMetric : public ImageToImageMetric
   /** Check if enough samples have been found to compute a reliable
    * estimate of the value/derivative; throws an exception if not. */
   void
-  CheckNumberOfSamples(unsigned long wanted) const;
+  CheckNumberOfSamples(const SizeValueType wanted) const;
 
   /** Methods for image derivative evaluation support **********/
 
diff --git a/Common/CostFunctions/itkAdvancedImageToImageMetric.hxx b/Common/CostFunctions/itkAdvancedImageToImageMetric.hxx
@@ -749,7 +749,7 @@ AdvancedImageToImageMetric<TFixedImage, TMovingImage>::AccumulateDerivativesThre
 
 template <typename TFixedImage, typename TMovingImage>
 void
-AdvancedImageToImageMetric<TFixedImage, TMovingImage>::CheckNumberOfSamples(unsigned long wanted) const
+AdvancedImageToImageMetric<TFixedImage, TMovingImage>::CheckNumberOfSamples(const SizeValueType wanted) const
 {
   if (const SizeValueType found{ Superclass::m_NumberOfPixelsCounted }; found < wanted * m_RequiredRatioOfValidSamples)
   {

Original file line number	Diff line number	Diff line change
`@@ -749,7 +749,7 @@ AdvancedImageToImageMetric<TFixedImage, TMovingImage>::AccumulateDerivativesThre`
`749`	`749`
`750`	`750`	`template <typename TFixedImage, typename TMovingImage>`
`751`	`751`	`void`
`752`		`-AdvancedImageToImageMetric<TFixedImage, TMovingImage>::CheckNumberOfSamples(unsigned long wanted) const`
	`752`	`+AdvancedImageToImageMetric<TFixedImage, TMovingImage>::CheckNumberOfSamples(const SizeValueType wanted) const`
`753`	`753`	`{`
`754`	`754`	`if (const SizeValueType found{ Superclass::m_NumberOfPixelsCounted }; found < wanted * m_RequiredRatioOfValidSamples)`
`755`	`755`	`{`