BUG: Fix calculation CenterOfRotationPoint in EulerStackTransform

N-Dekker · N-Dekker · commit 32106531128b · 2025-03-31T13:53:14.000+02:00
When the user did not explicitly specify "CenterOfRotation" or "CenterOfRotationPoint", the elements of `redDimCenterOfRotationPoint` were accidentally just assigned to themselves, in `EulerStackTransform::InitializeTransform()`. Effectively their values would then remain `0.0`. The bug appears already with the initial EulerStackTransform commit, 4dda84b "Added EulerStackTransform to trunkpublic", 1 March 2017.
diff --git a/Components/Transforms/EulerStackTransform/elxEulerStackTransform.hxx b/Components/Transforms/EulerStackTransform/elxEulerStackTransform.hxx
@@ -234,7 +234,7 @@ EulerStackTransform<TElastix>::InitializeTransform()
 
     for (unsigned int k = 0; k < ReducedSpaceDimension; ++k)
     {
-      redDimCenterOfRotationPoint[k] = redDimCenterOfRotationPoint[k];
+      redDimCenterOfRotationPoint[k] = centerOfRotationPoint[k];
     }
 
     /** FIX: why may the cop not work when using direction cosines? */

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ EulerStackTransform<TElastix>::InitializeTransform()`
`234`	`234`
`235`	`235`	`for (unsigned int k = 0; k < ReducedSpaceDimension; ++k)`
`236`	`236`	`{`
`237`		`- redDimCenterOfRotationPoint[k] = redDimCenterOfRotationPoint[k];`
	`237`	`+ redDimCenterOfRotationPoint[k] = centerOfRotationPoint[k];`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`/** FIX: why may the cop not work when using direction cosines? */`