Skip to content

Commit cbfd920

Browse files
authored
Merge pull request #742 from Stremio/fix/multiselect-menu-height
fix: multiselectMenu and Multiselect height
2 parents e6214be + c2dc381 commit cbfd920

File tree

8 files changed

+23
-16
lines changed

8 files changed

+23
-16
lines changed

src/common/ModalDialog/styles.less

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
.body-container {
8383
flex: 1;
8484
align-self: stretch;
85-
overflow-y: auto;
85+
overflow: visible;
8686
padding: 2rem 0;
8787

8888
&:last-child {

src/common/Multiselect/styles.less

+12
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
popup-menu-container: menu-container;
88
}
99

10+
@parent-height: 10rem;
11+
1012
.label-container {
1113
display: flex;
1214
flex-direction: row;
@@ -48,6 +50,8 @@
4850

4951
.modal-container, .popup-menu-container {
5052
.menu-container {
53+
max-height: calc(3.2rem * 7);
54+
5155
.option-container {
5256
display: flex;
5357
flex-direction: row;
@@ -101,4 +105,12 @@
101105
}
102106
}
103107
}
108+
}
109+
110+
@media (orientation: landscape) and (max-width: @xsmall) {
111+
.modal-container, .popup-menu-container {
112+
.menu-container {
113+
max-height: calc(100dvh - var(--horizontal-nav-bar-size) - @parent-height);
114+
}
115+
}
104116
}

src/common/MultiselectMenu/Dropdown/Dropdown.less

+5-3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
@import (reference) '~stremio/common/screen-sizes.less';
44

5+
@parent-height: 10rem;
6+
57
.dropdown {
68
background: var(--modal-background-color);
79
display: none;
@@ -16,7 +18,7 @@
1618

1719
&.open {
1820
display: block;
19-
max-height: calc(3.2rem * 10);
21+
max-height: calc(3.3rem * 7);
2022
overflow: auto;
2123
}
2224

@@ -33,10 +35,10 @@
3335
}
3436
}
3537

36-
@media only screen and (max-width: @minimum) {
38+
@media (orientation: landscape) and (max-width: @xsmall) {
3739
.dropdown {
3840
&.open {
39-
max-height: calc(3.2rem * 7);
41+
max-height: calc(100dvh - var(--horizontal-nav-bar-size) - @parent-height);
4042
}
4143
}
4244
}

src/routes/Addons/styles.less

+4-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@
8989
margin-right: 1.5rem;
9090

9191
.multiselect-menu-container {
92-
max-height: calc(3.2rem * 7);
9392
overflow: auto;
9493
}
9594
}
@@ -156,6 +155,10 @@
156155
.select-input-container {
157156
height: 3rem;
158157

158+
.multiselect-menu-container {
159+
overflow: auto;
160+
}
161+
159162
&:not(:last-child) {
160163
margin-bottom: 1rem;
161164
}

src/routes/Discover/styles.less

+1-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
}
5858

5959
.multiselect-menu-container {
60-
max-height: calc(3.2rem * 7);
6160
overflow: auto;
6261
}
6362
}
@@ -220,7 +219,7 @@
220219
}
221220

222221
.multiselect-menu-container {
223-
max-height: calc(3.2rem * 4);
222+
max-height: calc(3.2rem * 3);
224223
overflow: auto;
225224
}
226225
}

src/routes/Library/styles.less

-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
}
4343

4444
.multiselect-menu-container {
45-
max-height: calc(3.2rem * 7);
4645
overflow: auto;
4746
}
4847
}

src/routes/MetaDetails/StreamsList/styles.less

-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@
124124
}
125125

126126
.multiselect-menu-container {
127-
max-height: calc(3.2rem * 7);
128127
overflow: auto;
129128
}
130129
}

src/routes/MetaDetails/VideosList/SeasonsBar/styles.less

-7
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
}
7878

7979
.multiselect-menu-container {
80-
max-height: calc(3.2rem * 7);
8180
overflow: auto;
8281
}
8382
}
@@ -86,11 +85,5 @@
8685
@media only screen and (max-width: @minimum) {
8786
.seasons-bar-container {
8887
height: 6rem;
89-
90-
.seasons-popup-label-container {
91-
.multiselect-menu-container {
92-
max-height: calc(3.2rem * 3);
93-
}
94-
}
9588
}
9689
}

0 commit comments

Comments
 (0)