Skip to content

Translate date displays in jupiter-apis index tables #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mathis-marcotte opened this issue Aug 8, 2023 · 2 comments · Fixed by #275
Closed

Translate date displays in jupiter-apis index tables #272

mathis-marcotte opened this issue Aug 8, 2023 · 2 comments · Fixed by #275
Assignees
@mathis-marcotte

Comments

@mathis-marcotte
Copy link
Contributor

The formatted dates aren't being translated

image

These use the date-fns module, which does support i18n. But we are also using a version that is quite old (v1.29.0 compared to v2.30.0), so updating the version of date-fns might be required to fix this issue.
@mathis-marcotte mathis-marcotte mentioned this issue Aug 8, 2023
Closed
6 tasks
@mathis-marcotte mathis-marcotte self-assigned this Aug 9, 2023
@mathis-marcotte
Copy link
Contributor Author

We just needed to set the locale in the function for this.

@mathis-marcotte mathis-marcotte mentioned this issue Aug 16, 2023
Merged
@mathis-marcotte
Copy link
Contributor Author

image

@mathis-marcotte mathis-marcotte mentioned this issue Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathis-marcotte mathis-marcotte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Translated distanceInWords StatCan/jupyter-apis
1 participant
@mathis-marcotte