Skip to content

Fix the javascript tests following KF1.7 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathis-marcotte opened this issue Jun 12, 2023 · 2 comments
Closed

Fix the javascript tests following KF1.7 #245

mathis-marcotte opened this issue Jun 12, 2023 · 2 comments
Assignees

Comments

@mathis-marcotte
Copy link
Contributor

We will need to fix the unit tests for the jupyter frontend.
That means all those *.spec.ts that can be found under both the frontend/jupyter folder and the frontnend/common folder.
That needs to be fixed so that the npm run test:prod can run successfully.

@mathis-marcotte
Copy link
Contributor Author

Started fixing some of these for running npm run test:prod. There is still some left :
image

@mathis-marcotte mathis-marcotte self-assigned this Jun 14, 2023
@mathis-marcotte
Copy link
Contributor Author

mathis-marcotte commented Jun 15, 2023

Fixed the remaining failed tests. The fails where mainly happening because we needed to adjust the references to packages based on our custom code.
These are from our /jupyter
image

And from /common
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant