Skip to content

"Last Activity" Column not being populated #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathis-marcotte opened this issue Jun 5, 2023 · 1 comment
Closed

"Last Activity" Column not being populated #243

mathis-marcotte opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels

Comments

@mathis-marcotte
Copy link
Contributor

image

We aren't returning the value for "Last Activity". https://github.com/StatCan/jupyter-apis/blob/main/notebooks.go#L316

The value is retrieved from the notebooks.kubeflow.org/last-activity annotation from a notebook that is running.

Upstream does return it. https://github.com/kubeflow/kubeflow/blob/v1.7.0/components/crud-web-apps/jupyter/backend/apps/common/utils.py#L117

@mathis-marcotte
Copy link
Contributor Author

mathis-marcotte commented Jul 6, 2023

Closing this ticket. The issue is resolved in #254 .
The last_activity column not being returned was resulting in a null value which was breaking the filtering on the notebooks table.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant