Skip to content

Update jupyter-apis form frontend to KF1.7 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
97 tasks done
mathis-marcotte opened this issue Apr 17, 2023 · 1 comment
Closed
97 tasks done

Update jupyter-apis form frontend to KF1.7 #219

mathis-marcotte opened this issue Apr 17, 2023 · 1 comment
Assignees

Comments

@mathis-marcotte
Copy link
Contributor

mathis-marcotte commented Apr 17, 2023

Update the frontend form for jupyter to match upstream while making sure to not remove our custom code.

SRC App Pages Form

jupyter/frontend/src/app/pages/form/form-new

  • form-new.component.html
  • form-new.component.scss
  • form-new.component.spec.ts
  • form-new.component.ts
  • form-new.module.ts
  • utils.ts

jupyter/frontend/src/app/pages/form/form-new/form-advanced-options

  • form-advanced-options.component.html
  • form-advanced-options.component.scss
  • form-advanced-options.component.spec.ts
  • form-advanced-options.component.ts
  • form-advanced-options.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-affinity-tolerations

  • form-affinity-tolerations.component.html
  • form-affinity-tolerations.component.scss
  • form-affinity-tolerations.component.spec.ts
  • form-affinity-tolerations.component.ts
  • form-affinity-tolerations.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-configurations

  • form-configurations.component.html
  • form-configurations.component.scss
  • form-configurations.component.spec.ts
  • form-configurations.component.ts
  • form-configurations.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-cpu-ram

  • form-cpu-ram.component.html : will need some i18n, we could also re-evaluate why we can't take their lib-positive-input component
  • form-cpu-ram.component.scss
  • form-cpu-ram.component.spec.ts
  • form-cpu-ram.component.ts
  • form-cpu-ram.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-data-volumes

  • form-data-volumes.component.html : new i18n
  • form-data-volumes.component.scss
  • form-data-volumes.component.spec.ts
  • form-data-volumes.component.ts
  • form-data-volumes.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-gpus

  • form-gpus.component.html
  • form-gpus.component.scss
  • form-gpus.component.spec.ts
  • form-gpus.component.ts
  • form-gpus.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-image

  • form-image.component.html : new i18n needed, also will need to define text for the SAS image
  • form-image.component.scss
  • form-image.component.spec.ts
  • form-image.component.ts
  • form-image.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-name

  • form-name.component.html
  • form-name.component.scss
  • form-name.component.spec.ts
  • form-name.component.ts
  • form-name.module.ts

jupyter/frontend/src/app/pages/form/form-new/form-workspace-volume

  • form-workspace-volume.component.html
  • form-workspace-volume.component.scss
  • form-workspace-volume.component.spec.ts
  • form-workspace-volume.component.ts
  • form-workspace-volume.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume

  • volume.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/existing

  • existing-volume.component.html
  • existing-volume.component.scss
  • existing-volume.component.spec.ts
  • existing-volume.component.ts
  • existing-volume.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/existing/pvc

  • pvc.component.html
  • pvc.component.scss
  • pvc.component.spec.ts
  • pvc.component.ts : there's a function called that changed from getPVCs to getVolumes which we will have to make sure still works
  • pvc.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/mount

  • mount.component.scss
  • mount.component.spec.ts
  • mount.component.html
  • mount.module.ts
  • mount.component.ts : this got update a bit and we'll need to make sure the validators still work as expected

jupyter/frontend/src/app/pages/form/form-new/volume/new

  • new.component.html
  • new.component.scss
  • new.component.spec.ts
  • new.component.ts
  • new.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/new/access-modes

  • access-modes.component.html
  • access-modes.component.scss
  • access-modes.component.spec.ts
  • access-modes.component.ts
  • access-modes.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/new/name

  • name.component.html
  • name.component.scss
  • name.component.spec.ts
  • name.component.ts
  • name.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/new/rok-url

  • rok-url.component.html
  • rok-url.component.scss
  • rok-url.component.spec.ts
  • rok-url.component.ts
  • rok-url.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/new/size

  • size.component.html
  • size.component.scss
  • size.component.spec.ts
  • size.component.ts
  • size.module.ts

jupyter/frontend/src/app/pages/form/form-new/volume/new/storage-class

  • storage-class.component.html
  • storage-class.component.scss
  • storage-class.component.spec.ts
  • storage-class.component.ts
  • storage-class.module.ts
@mathis-marcotte mathis-marcotte transferred this issue from StatCan/aaw Apr 17, 2023
@mathis-marcotte mathis-marcotte self-assigned this May 29, 2023
@mathis-marcotte
Copy link
Contributor Author

A change to note is that the folder got renamed from form/form-default to form/form-new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant