Skip to content

Evaluate Jupyter-apis backend for KF1.7 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathis-marcotte opened this issue Apr 17, 2023 · 1 comment
Closed

Evaluate Jupyter-apis backend for KF1.7 #216

mathis-marcotte opened this issue Apr 17, 2023 · 1 comment
Assignees

Comments

@mathis-marcotte
Copy link
Contributor

mathis-marcotte commented Apr 17, 2023

KF1.7 EPIC

The backend will need to be evaluated to make sure of two things:

  • that the endpoints we already have in Golang still match logically with the python endpoints from upstream.

  • that the endpoints we need for the new features are implemented.
    The main endpoints that we will need to add are the ones needed in the new "Details" pages for notebooks and volumes. On a quick look, there are these GET requests for getting a single resource here for notebooks and here for volumes. But there may be more routes that need to be implemented on our side besides those two.

Will have to make sure to check under the backend folders for "common", "jupyter", and "volumes" in crud-web-apps

@mathis-marcotte mathis-marcotte transferred this issue from StatCan/aaw Apr 17, 2023
@mathis-marcotte mathis-marcotte self-assigned this May 17, 2023
@mathis-marcotte mathis-marcotte changed the title Update Jupyter-apis backend to KF1.7 Evaluate Jupyter-apis backend for KF1.7 May 17, 2023
@mathis-marcotte
Copy link
Contributor Author

mathis-marcotte commented May 17, 2023

Looked at the code changes in the backend by comparing 1.7 with 1.6.
The majority of the differences outside of stuff like updated comments are the new requests that will need to be added in our own repo. So here is the list of what we will need to do on our side.

Add from Jupyter component

  • GET /api/namespaces/<namespace>/notebooks/<notebook_name>
  • GET /api/namespaces/<namespace>/notebooks/<notebook_name>/pod
  • GET /api/namespaces/<namespace>/notebooks/<notebook_name>/pod/<pod_name>/logs
  • GET /api/namespaces/<namespace>/notebooks/<notebook_name>/events

Add from Volumes Component

  • GET /api/namespaces/<namespace>/pvcs/<pvc_name>
  • GET /api/namespaces/<namespace>/pvcs/<pvc_name>/pods
  • GET /api/namespaces/<namespace>/pvcs/<pvc_name>/events

Modify in volumes component

  • GET /api/namespaces/<namespace>/pvcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant