-
Notifications
You must be signed in to change notification settings - Fork 4
Deploy Angular i18n #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The current work can be seen in branch https://github.com/StatCan/jupyter-apis/tree/fix-i18n-angular There is currently an issue that the i18n files needed suche as messages.xlf are not in the right location. |
The image with the jwa + backend seems to finally build. Now it will be to test it locally to try and see if I can use port-forward on local |
Trying to figure out how to redirect the url when the api is called so it doesn't send the api call with a /fr or /en suffix. Using this site to test out the result https://nginx.viraptor.info//
|
We will need to add code to force the |
The Pr for the manifest is ready. |
(Adding Collin to reflect his work on this) |
Uh oh!
There was an error while loading. Please reload this page.
This is the logical next step of the investigation made in #126
TODOs
Those were included in the original ticket but since not all of them got to fr
Take standalone example from repo and integrated it with jupyter-apis repo. Specifically, make k8s folder, taskfile, k3d config, etc. so that we can build jupyter-apis
Dockerfile
and test locally https://github.com/wg102/k3d-example.Update jupyter-apis Dockerfile to include front-end build logic that aligns with KF 1.6 (i.e.
ng build --localize=...
). Specifically, we need to update the following lines: https://github.com/StatCan/jupyter-apis/blob/main/Dockerfile#L2-L17Update jupyter-apis Dockerfile base image to be alpine instead of scratch. Reason is that we need to be able to use
cp
in init container to move static files into stock NGINX container. https://github.com/StatCan/jupyter-apis/blob/main/Dockerfile#L30Remove static file serving logic from golang application (https://github.com/StatCan/jupyter-apis/blob/main/main.go#L250-L263) - reason is that NGINX static file server will handle this concern.
Update the jupyter-apis deployment (https://github.com/StatCan/aaw-kubeflow-manifests/blob/aaw-dev-cc-00/kustomize/apps/jupyter-web-app/base/deployment.yaml) to reflect the deployment strategy used in https://github.com/StatCan/aws-js-s3-explorer/blob/main/k8s/s3proxy-deploy.yaml. Specifically:
dist
folder.dist
static files onto the/etc/nginx/html
location of the nginx container (this is the default place that nginx serves static files from).jupyter-web-app-service
will continue to forward to the correct port./etc/nginx/nginx.conf
Change anything that references
/en
or/fr
to/jupyter/en
and/jupyter/fr
because in central dashboard we will access this via /jupyter prefix.Testing TODO
Steps:
The text was updated successfully, but these errors were encountered: