Skip to content

Upgrade 1.6: Fix Backend #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
wg102 opened this issue Aug 24, 2022 · 2 comments
Closed
2 tasks

Upgrade 1.6: Fix Backend #125

wg102 opened this issue Aug 24, 2022 · 2 comments
Assignees
Labels
size/L 4-5 days

Comments

@wg102
Copy link
Contributor

wg102 commented Aug 24, 2022

See issue StatCan/aaw#1242
This issue is part of the whole upgrade kubeflow.

The items or specifics will be written down after talking to Will.
After a quick chat with Will, it seems the way they have done the update previously is to launch the upstream jupyter-api, then open devtools and take a look at any of the requests that the webapp is making to the backend, along with their payloads and then update the golang schema for any corrections.

There are 3 parts of this issue: It might be wise to split the ticket in 3 as well?
Jupyter
Tensorboards
Volumes

This being said, we don't have the same UI as they do.
Per example, our Jupyter has some option theirs don't.
We use our own volume table. Might have changed.
We do not yet use Tensorboards, but we might want to include it.

TODO

  • Compare 1.6 crud web apps python application to the jupyter-web-apis golang application and review the logic endpoint by endpoint (make sure source code does the same thing in each case).
  • Test every case live against the aaw-dev cluster (e.g. once jupyter-web-apis is refactored, run it locally connecting to aaw-dev cluster and e.g. make postman requests for each endpoint case - include postman tests in jupyter-apis repo).
@wg102 wg102 self-assigned this Aug 24, 2022
@wg102 wg102 added the size/L 4-5 days label Aug 24, 2022
@wg102 wg102 mentioned this issue Aug 24, 2022
14 tasks
@wg102 wg102 removed their assignment Aug 24, 2022
@Collinbrown95
Copy link
Contributor

Collinbrown95 commented Sep 1, 2022

Notes from meeting

  • this relates to the notebook tab in the central dashboard menu
  • the "new server" part is also part of jupyter apis

Development Workflow

Note: 2 ways to set this up (1) connect to dev cluster directly or (2) mock k3d cluster and point jupyter-web api to k3d cluster

  1. Run upstream version of app https://github.com/kubeflow/kubeflow/tree/v1.6.0/components/crud-web-apps

    • need to run each of these (jupyter and volumes) independently locally as their own web app, instructions are in README of each folder.
  2. Run our home grown version of jupyter webapps

Features to test

jupyter APIs

  • RESTART CREATE DELETE STOP notebooks

volume table

  • we have our own home-grown version of this that is completely separate from the upstream code.

@Collinbrown95 Collinbrown95 self-assigned this Sep 7, 2022
@wg102 wg102 changed the title Upgrade 1.4: Fix Backend Upgrade 1.6: Fix Backend Sep 9, 2022
@cboin1996
Copy link
Contributor

cboin1996 commented Sep 13, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 4-5 days
Projects
None yet
Development

No branches or pull requests

3 participants