Skip to content

Commit 3f6d99b

Browse files
authored
Merge pull request #115 from StatCan/remove-kubecost
Remove kubecost table and fix i18n
2 parents e1afc90 + c452704 commit 3f6d99b

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

frontend/jupyter/src/app/pages/form/form-default/volume/volume.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
<!-- Volume Name Input -->
1717
<mat-form-field appearance="outline" id="name">
18-
<mat-label>Name</mat-label>
18+
<mat-label>{{ 'common.name' | translate }}</mat-label>
1919
<input
2020
matInput
2121
formControlName="name"

frontend/jupyter/src/app/pages/index/index-default/index-default.component.html

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,16 @@
1414
(actionsEmitter)="reactVolumeToAction($event)"
1515
></lib-resource-table>
1616

17-
<lib-resource-table *ngIf="this.getCostStatus() == true; else error"
17+
<!-- todo: Fix kubecost -->
18+
<!-- <lib-resource-table *ngIf="this.getCostStatus() == true; else error"
1819
[config]="costConfig"
1920
[data]="processedCostData"
2021
[trackByFn]="costTrackByFn"
21-
></lib-resource-table>
22+
></lib-resource-table> -->
23+
24+
<div class="center-flex ">
25+
<p>{{ 'jupyter.costTable.kubeCostError' | translate }}</p>
26+
</div>
2227

2328
<ng-template #error>
2429
<div *ngIf="this.getCostStatus() == false" class="center-flex costerror">

frontend/jupyter/src/assets/i18n/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@
138138
"gpus": "GPUs",
139139
"storage": "Storage",
140140
"total": "Total",
141-
"errMessage": "Failed to retrieve cost information"
141+
"errMessage": "Failed to retrieve cost information",
142+
"kubeCostError": "Cost information is temporarily unavailable"
142143
}
143144
},
144145
"common": {

frontend/jupyter/src/assets/i18n/fr.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,8 @@
137137
"gpus": "GPUs",
138138
"storage": "Stockage",
139139
"total": "Total",
140-
"errMessage": "Échec de la récupération des informations des coûts."
140+
"errMessage": "Échec de la récupération des informations des coûts.",
141+
"kubeCostError": "Les informations sur les coûts sont temporairement non disponible"
141142
}
142143
},
143144
"common": {

0 commit comments

Comments
 (0)