Skip to content

"Only owner and team can mount" not defining individually #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dracconus opened this issue Nov 5, 2023 · 1 comment
Open

"Only owner and team can mount" not defining individually #18

Dracconus opened this issue Nov 5, 2023 · 1 comment

Comments

@Dracconus
Copy link

Dracconus commented Nov 5, 2023

Earlier today I set Minicopter's "Only Owner and team can mount" to "true" whilst simulatenously having the Attack heli, and scrap heli set to "false" and the "false" flag was overriding the minicopter's true.

Not sure if it's something you'll be able to replicate, or if it was due to some sort of interference from MinicopterOptions somehow (I doubt it, though.)

Also, is there any way you can make it so that there's a config option for "Only owner and team can CONTROL/loot fuel containers" instead of just mount? I'd be more than happy to throw you some coffee or beer money for this customized edit if you can. I'd like to be able to give people rides without allowing them control over my fuel-less mini.

@WheteThunger
Copy link
Contributor

Thank you for reporting this issue. Sorry for missing it, I wasn't subscribed to issues on this repository since it isn't mine, but I have subscribed now. Since this is a uMod plugin, the recommended way to get support going forward is via the uMod forums.

I confirmed in the code that the CanMountEntity method is missing a check for the specific type of helicopter, so the symptom you described makes sense. This happened because originally the feature was enabled/disabled by subscribing/unsubscribing a hook, and so I forgot to add a check in the hook function itself when transitioning to multiple types of helicopters. A similar miss was originally done for the Destroy on disconnect option, but that was identified and fixed during the v3.0.0 beta.

I've made a fix on a branch, which you can get at the following link.
https://github.com/WheteThunger/SpawnHeli

As for your suggestion regarding giving players rides, that might be a good fit for the Vehicle Deployed Locks plugin, where players that authenticate with the code lock's guest code could potentially only mount the vehicle (possibly only passenger seats), with no access to other vehicle features. Either way, please open a feature request on the respective uMod plugin forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants