Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not parse the collision and visibility strings of the Team packet #3800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Outfluencer
Copy link
Collaborator

Closes #3799

@NEZNAMY
Copy link

NEZNAMY commented Mar 8, 2025

Wouldn't it be better to parse it the way vanilla does and ignore invalid values (evaluate them to always)?

This is just a compensation for buggy plugins using ProtocolLib (which totally doesn't have 200 bug reports).

@Outfluencer
Copy link
Collaborator Author

i think just forward them is better, it guarantees we don't break any behaviour.

@Janmm14
Copy link
Contributor

Janmm14 commented Mar 8, 2025

If the client is ignoring these values, what about just specialcasing unknown values as null and write them as "null" string? no need for saving as string.
Or maybe we could even attempt to rescue it by checking lowercase in enum as well?

@Outfluencer
Copy link
Collaborator Author

You can send anything the client just ignores it if it cant parse it

@Janmm14
Copy link
Contributor

Janmm14 commented Mar 8, 2025

You can send anything the client just ignores it if it cant parse it

I think you commeted before I, immediately after posting, changed my comment. I don't see why we need to preserve which ignored value is sent.

@Outfluencer
Copy link
Collaborator Author

I am not sure if every minecraft version handles it exactly the same, and i don't want to lookup the code in any minecraft version bungee supports,
Thats why i just forwarded it, by forwarding we know that nothing will break, and we have the same behaviour as before the team packet changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could not decode packet on 1.20.4 paper
3 participants