SCANMAVEN-279 Clean up old code (#290)

Author: tomasz-tylenda-sonarsource

sonar-maven-plugin/src/main/java/org/sonarsource/scanner/maven/bootstrap/MavenUtils.java

@@ -72,22 +72,6 @@ public static String getPluginSetting(MavenProject project, String groupId, Stri
     return defaultValue;
   }
 
-  /**
-   * Returns first non null object or null if all objects are null
-   *
-   * @param objs
-   * @return First null argument, or null if they are all null
-   */
-  @SafeVarargs
-  public static <T> T coalesce(T... objs) {
-    for (T o : objs) {
-      if (o != null) {
-        return o;
-      }
-    }
-    return null;
-  }
-
   static void putAll(Properties src, Map<String, String> dest) {
     for (final String name : src.stringPropertyNames()) {
       dest.put(name, src.getProperty(name));

sonar-maven-plugin/src/main/java/org/sonarsource/scanner/maven/bootstrap/ScannerBootstrapper.java

@@ -70,7 +70,7 @@ public void execute() throws MojoExecutionException {
     logEnvironmentInformation();
     try (ScannerEngineBootstrapResult bootstrapResult = bootstrapper.bootstrap()) {
       if (!bootstrapResult.isSuccessful()) {
-        throw new MojoFailureException("The scanner boostrapping has failed! See the logs for more details.");
+        throw new MojoFailureException("The scanner bootstrapping has failed! See the logs for more details.");
       }
       try (ScannerEngineFacade engineFacade = bootstrapResult.getEngineFacade()) {
         if (!engineFacade.isSonarQubeCloud()) {

sonar-maven-plugin/src/main/java/org/sonarsource/scanner/maven/bootstrap/SourceCollector.java

@@ -100,7 +100,7 @@ public SourceCollector(Set<Path> existingSources, Set<Path> directoriesToIgnore,
   }
 
   @Override
-  public FileVisitResult preVisitDirectory(Path path, BasicFileAttributes basicFileAttributes) throws IOException {
+  public FileVisitResult preVisitDirectory(Path path, BasicFileAttributes basicFileAttributes) {
     if (
       isHidden(path) ||
       isExcludedDirectory(path) ||
@@ -137,12 +137,12 @@ public FileVisitResult visitFile(Path path, BasicFileAttributes basicFileAttribu
   }
 
   @Override
-  public FileVisitResult visitFileFailed(Path path, IOException e) throws IOException {
+  public FileVisitResult visitFileFailed(Path path, IOException e) {
     return null;
   }
 
   @Override
-  public FileVisitResult postVisitDirectory(Path path, IOException e) throws IOException {
+  public FileVisitResult postVisitDirectory(Path path, IOException e) {
     return FileVisitResult.CONTINUE;
   }
 }

sonar-maven-plugin/src/test/java/org/sonarsource/scanner/maven/bootstrap/MavenUtilsTest.java

@@ -27,16 +27,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 class MavenUtilsTest {
-  @Test
-  void testCoalesce() {
-    Object o1 = null;
-    Object o2 = null;
-    Object o3 = new Object();
-
-    assertThat(MavenUtils.coalesce(o1, o2)).isNull();
-    assertThat(MavenUtils.coalesce(o1, o3, o2)).isEqualTo(o3);
-  }
-
   @Test
   void testJoinAsCsv() {
     List<String> values = Arrays.asList("/home/users/me/artifact-123,456.jar", "/opt/lib");

sonar-maven-plugin/src/test/java/org/sonarsource/scanner/maven/bootstrap/ScannerBootstrapperTest.java

@@ -160,7 +160,7 @@ void when_ScannerEngineBootstrapper_is_not_successful_getEngineFacade_should_not
 
     assertThatThrownBy( () -> scannerBootstrapper.execute())
       .isInstanceOf(MojoExecutionException.class)
-      .hasMessage("The scanner boostrapping has failed! See the logs for more details.");
+      .hasMessage("The scanner bootstrapping has failed! See the logs for more details.");
   }
 
   @Test