Add sv2 noise protocol

Also introduce libbitcoin_sv2.

Co-Authored-By: Christopher Coverdale <[email protected]>

Author: Sjors

CMakeLists.txt

@@ -150,6 +150,8 @@ if(ENABLE_IPC AND WITH_EXTERNAL_LIBMULTIPROCESS)
   )
 endif()
 
+option(WITH_SV2 "Enable Stratum v2 functionality." ON)
+
 cmake_dependent_option(BUILD_GUI_TESTS "Build test_bitcoin-qt executable." ON "BUILD_GUI;BUILD_TESTS" OFF)
 if(BUILD_GUI)
   set(qt_components Core Gui Widgets LinguistTools)
@@ -686,6 +688,7 @@ message("  IPC ................................. ${ipc_status}")
 message("  USDT tracing ........................ ${WITH_USDT}")
 message("  QR code (GUI) ....................... ${WITH_QRENCODE}")
 message("  DBus (GUI) .......................... ${WITH_DBUS}")
+message("  Stratum v2 .......................... ${WITH_SV2}")
 message("Tests:")
 message("  test_bitcoin ........................ ${BUILD_TESTS}")
 message("  test_bitcoin-qt ..................... ${BUILD_GUI_TESTS}")

doc/design/libraries.md

@@ -14,6 +14,7 @@
 | *libbitcoin_wallet*      | Wallet functionality used by *bitcoind* and *bitcoin-wallet* executables. |
 | *libbitcoin_wallet_tool* | Lower-level wallet functionality used by *bitcoin-wallet* executable. |
 | *libbitcoin_zmq*         | [ZeroMQ](../zmq.md) functionality used by *bitcoind* and *bitcoin-qt* executables. |
+| *libbitcoin_sv2*         | Stratum v2 functionality (usage TBD) |
 
 ## Conventions
 

src/CMakeLists.txt

@@ -103,6 +103,9 @@ add_subdirectory(util)
 if(ENABLE_IPC)
   add_subdirectory(ipc)
 endif()
+if(WITH_SV2)
+  add_subdirectory(sv2)
+endif()
 
 add_library(bitcoin_consensus STATIC EXCLUDE_FROM_ALL
   arith_uint256.cpp

src/pubkey.h

@@ -319,7 +319,7 @@ struct EllSwiftPubKey
     /** Construct a new ellswift public key from a given serialization. */
     EllSwiftPubKey(std::span<const std::byte> ellswift) noexcept;
 
-    /** Decode to normal compressed CPubKey (for debugging purposes). */
+    /** Decode to normal compressed CPubKey. */
     CPubKey Decode() const;
 
     // Read-only access for serialization.

src/sv2/CMakeLists.txt

@@ -0,0 +1,15 @@
+# Copyright (c) 2024-present The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or https://opensource.org/license/mit/.
+
+add_library(bitcoin_sv2 STATIC EXCLUDE_FROM_ALL
+  noise.cpp
+)
+
+target_link_libraries(bitcoin_sv2
+  PRIVATE
+    core_interface
+    bitcoin_clientversion
+    bitcoin_crypto
+    $<$<PLATFORM_ID:Windows>:ws2_32>
+)