Skip to content

Commit 3319668

Browse files
committed
ci: disable things Template Provider doesn't need
The Template Provider binary: * won't have a wallet * probably won't have a gui (maybe after the QT revamp) * doesn't use the functional test framework * doesn't support Windows Disable some CI stuff to speed it up. This is not a complete list, because: 1. That would be too hard to rebase 2. Some things might be added later, e.g. tracepoints
1 parent b6595b0 commit 3319668

11 files changed

+16
-11
lines changed

.cirrus.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ env: # Global defaults
77
CCACHE_MAXSIZE: "200M"
88
CCACHE_DIR: "/tmp/ccache_dir"
99
CCACHE_NOHASHDIR: "1" # Debug info might contain a stale path if the build dir changes, but this is fine
10+
RUN_FUNCTIONAL_TESTS: false # Template Provider doesn't have its own functional tests
1011

1112
# A self-hosted machine(s) can be used via Cirrus CI. It can be configured with
1213
# multiple users to run tasks in parallel. No sudo permission is required.
@@ -136,6 +137,8 @@ task:
136137

137138
task:
138139
name: 'Win64, unit tests, no gui tests, no functional tests'
140+
# Template Provider doesn't support Windows (can't use skip keyword twice)
141+
only_if: false
139142
<< : *GLOBAL_TASK_TEMPLATE
140143
persistent_worker:
141144
labels:

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ jobs:
139139
runs-on: windows-2022
140140

141141
# No need to run on the read-only mirror, unless it is a PR.
142-
if: github.repository != 'bitcoin-core/gui' || github.event_name == 'pull_request'
142+
# Template Provider does not support Windows
143+
if: false # github.repository != 'bitcoin-core/gui' || github.event_name == 'pull_request'
143144

144145
env:
145146
CCACHE_MAXSIZE: '200M'

ci/test/00_setup_env_i686_centos.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ export CI_BASE_PACKAGES="gcc-c++ glibc-devel.x86_64 libstdc++-devel.x86_64 glibc
1313
export PIP_PACKAGES="pyzmq"
1414
export GOAL="install"
1515
export NO_WERROR=1 # Suppress error: #warning _FORTIFY_SOURCE > 2 is treated like 2 on this platform [-Werror=cpp]
16-
export BITCOIN_CONFIG="--enable-zmq --with-gui=qt5 --enable-reduce-exports"
16+
export BITCOIN_CONFIG="--enable-reduce-exports"
1717
export CONFIG_SHELL="/bin/dash"

ci/test/00_setup_env_mac_cross.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ export XCODE_VERSION=15.0
1616
export XCODE_BUILD_ID=15A240d
1717
export RUN_UNIT_TESTS=false
1818
export RUN_FUNCTIONAL_TESTS=false
19-
export GOAL="deploy"
20-
export BITCOIN_CONFIG="--with-gui --enable-reduce-exports"
19+
export GOAL="install"
20+
export BITCOIN_CONFIG="--enable-reduce-exports"

ci/test/00_setup_env_mac_native.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export HOST=x86_64-apple-darwin
1111
# Therefore, `--break-system-packages` is needed.
1212
export PIP_PACKAGES="--break-system-packages zmq"
1313
export GOAL="install"
14-
export BITCOIN_CONFIG="--with-gui --with-miniupnpc --with-natpmp --enable-reduce-exports"
14+
export BITCOIN_CONFIG="--enable-reduce-exports"
1515
export CI_OS_NAME="macos"
1616
export NO_DEPENDS=1
1717
export OSX_SDK=""

ci/test/00_setup_env_native_asan.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export CONTAINER_NAME=ci_native_asan
2222
export PACKAGES="systemtap-sdt-dev clang-18 llvm-18 libclang-rt-18-dev python3-zmq qtbase5-dev qttools5-dev-tools libevent-dev libboost-dev libdb5.3++-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev libqrencode-dev libsqlite3-dev ${BPFCC_PACKAGE}"
2323
export NO_DEPENDS=1
2424
export GOAL="install"
25-
export BITCOIN_CONFIG="--enable-usdt --enable-zmq --with-incompatible-bdb --with-gui=qt5 \
25+
export BITCOIN_CONFIG="--enable-usdt \
2626
CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER' \
2727
--with-sanitizers=address,float-divide-by-zero,integer,undefined \
2828
CC='clang-18 -ftrivial-auto-var-init=pattern' CXX='clang++-18 -ftrivial-auto-var-init=pattern'"

ci/test/00_setup_env_native_previous_releases.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ export RUN_UNIT_TESTS_SEQUENTIAL="true"
1616
export RUN_UNIT_TESTS="false"
1717
export GOAL="install"
1818
export DOWNLOAD_PREVIOUS_RELEASES="true"
19-
export BITCOIN_CONFIG="--enable-zmq --with-gui=qt5 --enable-reduce-exports --enable-debug \
19+
export BITCOIN_CONFIG="--enable-reduce-exports --enable-debug \
2020
CFLAGS=\"-g0 -O2 -funsigned-char\" CPPFLAGS='-DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE' CXXFLAGS=\"-g0 -O2 -funsigned-char\""

ci/test/00_setup_env_native_tidy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ export RUN_FUNCTIONAL_TESTS=false
1616
export RUN_FUZZ_TESTS=false
1717
export RUN_TIDY=true
1818
export GOAL="install"
19-
export BITCOIN_CONFIG="CC=clang-${TIDY_LLVM_V} CXX=clang++-${TIDY_LLVM_V} --with-incompatible-bdb --disable-hardening CFLAGS='-O0 -g0' CXXFLAGS='-O0 -g0'"
19+
export BITCOIN_CONFIG="CC=clang-${TIDY_LLVM_V} CXX=clang++-${TIDY_LLVM_V} --disable-hardening CFLAGS='-O0 -g0' CXXFLAGS='-O0 -g0'"
2020
export CCACHE_MAXSIZE=200M

ci/test/00_setup_env_native_tsan.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ export CI_IMAGE_NAME_TAG="docker.io/ubuntu:24.04"
1111
export PACKAGES="clang-18 llvm-18 libclang-rt-18-dev libc++abi-18-dev libc++-18-dev python3-zmq"
1212
export DEP_OPTS="CC=clang-18 CXX='clang++-18 -stdlib=libc++'"
1313
export GOAL="install"
14-
export BITCOIN_CONFIG="--enable-zmq CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER -DDEBUG_LOCKCONTENTION' --with-sanitizers=thread"
14+
export BITCOIN_CONFIG="CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER -DDEBUG_LOCKCONTENTION' --with-sanitizers=thread"

ci/test/00_setup_env_native_valgrind.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ export USE_VALGRIND=1
1313
export NO_DEPENDS=1
1414
export TEST_RUNNER_EXTRA="--exclude feature_init,rpc_bind,feature_bind_extra" # feature_init excluded for now, see https://github.com/bitcoin/bitcoin/issues/30011 ; bind tests excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547
1515
export GOAL="install"
16-
export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang-16 CXX=clang++-16" # TODO enable GUI
16+
export BITCOIN_CONFIG="CC=clang-16 CXX=clang++-16" # TODO enable GUI

0 commit comments

Comments
 (0)