Update to require eslint v9 (#473)

Author: BPScott

.changeset/hungry-penguins-punch.md

@@ -0,0 +1,7 @@
+---
+'@shopify/eslint-plugin': major
+---
+
+Update minimum eslint version to v9.27.0.
+
+When updating, you must also update the version of eslint installed as a sibling of `@shopify/eslint-plugin` to be at least v9.27.0.

package.json

@@ -17,7 +17,7 @@
     "@changesets/changelog-github": "^0.5.0",
     "@changesets/cli": "^2.27.10",
     "@types/jest": "^26.0.24",
-    "eslint": "^8.56.0",
+    "eslint": "^9.27.0",
     "fs-extra": "^9.0.0",
     "glob": "^7.1.6",
     "jest": "^29.6.2",

packages/eslint-plugin/lib/utilities/component-utils.js

@@ -42,7 +42,7 @@ function isExplicitComponent(node, context) {
   // FIXME: Remove try/catch when https://github.com/eslint/eslint-scope/issues/27 is implemented.
   try {
     comment = sourceCode.getJSDocComment(node);
-  } catch (err) {
+  } catch {
     comment = null;
   }
 
@@ -56,7 +56,7 @@ function isExplicitComponent(node, context) {
       unwrap: true,
       tags: ['extends', 'augments'],
     });
-  } catch (err) {
+  } catch {
     // handle a bug in the archived `doctrine`, see #2596
     return false;
   }

packages/eslint-plugin/package.json

@@ -48,7 +48,7 @@
     "typescript-eslint": "^8.18.0"
   },
   "peerDependencies": {
-    "eslint": "^8.56.0"
+    "eslint": "^9.27.0"
   },
   "devDependencies": {
     "react": "^16.13.1",

packages/eslint-plugin/tests/lib/rules/binary-assignment-parens.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/binary-assignment-parens');
 

packages/eslint-plugin/tests/lib/rules/class-property-semi.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/class-property-semi');
 

packages/eslint-plugin/tests/lib/rules/images-no-direct-imports.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const {fixtureFile} = require('../../utilities');
 const rule = require('../../../lib/rules/images-no-direct-imports');

packages/eslint-plugin/tests/lib/rules/jest-no-all-mocks-methods.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/jest-no-all-mocks-methods');
 

packages/eslint-plugin/tests/lib/rules/jest-no-snapshots.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/jest-no-snapshots');
 

packages/eslint-plugin/tests/lib/rules/jsx-no-complex-expressions.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/jsx-no-complex-expressions');
 

packages/eslint-plugin/tests/lib/rules/jsx-no-hardcoded-content.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const {fixtureFile} = require('../../utilities');
 const rule = require('../../../lib/rules/jsx-no-hardcoded-content');

packages/eslint-plugin/tests/lib/rules/jsx-prefer-fragment-wrappers.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/jsx-prefer-fragment-wrappers');
 

packages/eslint-plugin/tests/lib/rules/no-ancestor-directory-import.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const {fixtureFile} = require('../../utilities');
 const rule = require('../../../lib/rules/no-ancestor-directory-import');

packages/eslint-plugin/tests/lib/rules/no-context-menu.test.js

@@ -3,12 +3,7 @@ const {RuleTester} = require('eslint');
 const rule = require('../../../lib/rules/no-context-menu');
 
 const ruleTester = new RuleTester({
-  parserOptions: {
-    ecmaVersion: 6,
-    ecmaFeatures: {
-      jsx: true,
-    },
-  },
+  languageOptions: {parserOptions: {ecmaFeatures: {jsx: true}}},
 });
 
 const error = {

packages/eslint-plugin/tests/lib/rules/no-fully-static-classes.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/no-fully-static-classes');
 

packages/eslint-plugin/tests/lib/rules/no-namespace-imports.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/no-namespace-imports');
 

packages/eslint-plugin/tests/lib/rules/no-useless-computed-properties.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/no-useless-computed-properties');
 

packages/eslint-plugin/tests/lib/rules/polaris-no-bare-stack-item.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const {fixtureFile} = require('../../utilities');
 const rule = require('../../../lib/rules/polaris-no-bare-stack-item');

packages/eslint-plugin/tests/lib/rules/polaris-prefer-sectioned-prop.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const {fixtureFile} = require('../../utilities');
 const rule = require('../../../lib/rules/polaris-prefer-sectioned-prop');

packages/eslint-plugin/tests/lib/rules/prefer-class-properties.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/prefer-class-properties');
 

packages/eslint-plugin/tests/lib/rules/prefer-early-return.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/prefer-early-return');
 

packages/eslint-plugin/tests/lib/rules/prefer-module-scope-constants.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/prefer-module-scope-constants');
 

packages/eslint-plugin/tests/lib/rules/prefer-twine.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/prefer-twine');
 

packages/eslint-plugin/tests/lib/rules/react-hooks-strict-return.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/react-hooks-strict-return');
 

packages/eslint-plugin/tests/lib/rules/react-initialize-state.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 const {parser: typescriptParser} = require('typescript-eslint');
 
 const rule = require('../../../lib/rules/react-initialize-state');

packages/eslint-plugin/tests/lib/rules/react-no-multiple-render-methods.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/react-no-multiple-render-methods');
 

packages/eslint-plugin/tests/lib/rules/react-prefer-private-members.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 const {parser: typescriptParser} = require('typescript-eslint');
 
 const rule = require('../../../lib/rules/react-prefer-private-members');

packages/eslint-plugin/tests/lib/rules/react-require-autocomplete.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/react-require-autocomplete');
 

packages/eslint-plugin/tests/lib/rules/react-type-state.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 const {parser: typescriptParser} = require('typescript-eslint');
 
 const rule = require('../../../lib/rules/react-type-state');

packages/eslint-plugin/tests/lib/rules/restrict-full-import.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/restrict-full-import');
 

packages/eslint-plugin/tests/lib/rules/sinon-no-restricted-features.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/sinon-no-restricted-features');
 

packages/eslint-plugin/tests/lib/rules/sinon-prefer-meaningful-assertions.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const rule = require('../../../lib/rules/sinon-prefer-meaningful-assertions');
 

packages/eslint-plugin/tests/lib/rules/strict-component-boundaries.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 
 const {fixtureFile} = require('../../utilities');
 const rule = require('../../../lib/rules/strict-component-boundaries');

packages/eslint-plugin/tests/lib/rules/typescript-prefer-build-client-schema.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 const {parser: typescriptParser} = require('typescript-eslint');
 
 const rule = require('../../../lib/rules/typescript-prefer-build-client-schema');

packages/eslint-plugin/tests/lib/rules/typescript-prefer-pascal-case-enums.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 const {parser: typescriptParser} = require('typescript-eslint');
 
 const rule = require('../../../lib/rules/typescript-prefer-pascal-case-enums');

packages/eslint-plugin/tests/lib/rules/typescript-prefer-singular-enums.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 const {parser: typescriptParser} = require('typescript-eslint');
 
 const rule = require('../../../lib/rules/typescript-prefer-singular-enums');

packages/eslint-plugin/tests/lib/rules/webpack-no-unnamed-dynamic-imports.test.js

@@ -1,4 +1,4 @@
-const {FlatRuleTester: RuleTester} = require('eslint/use-at-your-own-risk');
+const {RuleTester} = require('eslint');
 const {parser: typescriptParser} = require('typescript-eslint');
 
 const rule = require('../../../lib/rules/webpack-no-unnamed-dynamic-imports');