Upgrade RuboCop related gems #3367
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
03-28-upgrade_rubocop_related_gems
branch
6 times, most recently
from
1bf88c8 to
dc3352c
Compare
vinistock
force-pushed
the
03-28-upgrade_rubocop_related_gems
branch
from
dc3352c to
5f936b3
Compare
|
Just FYI, something in the new RuboCop versions is breaking our ability to show documentation links as part of the quick fixes, which is why I haven't shipped this yet. I have not managed to figure out what changed, but it looks this call to base_url_for is not consistently returning I suspect that's a symptom and not the root cause. Something may have changed in how settings are taken into account. |
vinistock
force-pushed
the
03-28-upgrade_rubocop_related_gems
branch
6 times, most recently
from
c112681 to
04cbfec
Compare
|
I guess we should look into this to make sure it's not a bug in RuboCop. //cc @koic |
|
@bbatsov it has been failing only on Windows, but I'm having trouble figuring out why. It could actually be something related to our tests and not RuboCop. |
vinistock
force-pushed
the
03-28-upgrade_rubocop_related_gems
branch
from
04cbfec to
914efdf
Compare
Motivation
Upgrade the rest of the outdated development gems, all related to RuboCop. There's a bug fix for the RuboCop add-on in these upgrades, so that we stop seeing an argument error while developing.