Skip to content

Commit 9b056be

Browse files
committed
Correctly retreive Playwright version
1 parent 41a3ac3 commit 9b056be

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/ci-a11y-vrt.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ jobs:
6363
# to use `pnpm why` to get the actual installed version.
6464
# 2. Because we're in a workspace, we need to make sure we get the version
6565
# for the workspace, not the root, hence the `--filter`.
66-
# 3. jq comes pre-installed in the Ubuntu runner, so we use that to get
67-
# the correct version string.
66+
# 3. grep & head come pre-installed in the Ubuntu runner, so we use them
67+
# to get the correct version string.
6868
# 4. Finally, we use sed to extract just the version number (eg; '1.22.0')
6969
# The result is stored in steps.playwright-version.outputs.version
7070
- name: Get installed Playwright version
7171
id: playwright-version
72-
run: echo "::set-output name=version::$(pnpm --filter='@shopify/polaris' why playwright --depth 1 --json | jq --raw-output '[.[].dependencies[].dependencies.playwright.version][0]')"
72+
run: echo "version=$(pnpm --filter='@shopify/polaris' why playwright --parseable | grep -E -o '/playwright@[^/]*?/' | head -1 | sed 's,/playwright@\([^/]*\)/,\1,')" >> $GITHUB_OUTPUT
7373

7474
# Attempt to restore the correct Playwright browser binaries based on the
7575
# currently installed version of Playwright (The browser binary versions

polaris-react/src/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,8 @@ export interface FilterInterface {
407407
hidden?: boolean;
408408
}
409409

410-
/* Useful for defining mutually exclusive props such as:
410+
/**
411+
* Useful for defining mutually exclusive props such as:
411412
*
412413
* interface MessageBasics {
413414
* timestamp?: number;

0 commit comments

Comments
 (0)