Merge pull request #244 from Shopify/bugsnag_proxy_for_observe

Enable Bugsnag Proxy for Observe Error Management Beta

Author: jklott

.golangci.yml

@@ -38,12 +38,8 @@ linters-settings:
     # put imports beginning with prefix after 3rd-party packages;
     # it's a comma-separated list of prefixes
     local-prefixes: github.com/Shopify/goose
-  golint:
-    min-confidence: 0
   lll:
     line-length: 140
-  maligned:
-    suggest-new: true
   gosec:
     excludes:
       - G115

bugsnag/bugsnagger.go

@@ -210,16 +210,48 @@ func httpRequestMiddleware(event *bugsnaggo.Event, config *bugsnaggo.Configurati
 	return nil
 }
 
-func (snagger *bugsnagger) Setup(apiKey string, commit string, env string, packages []string) {
-	// Add the bugsnag package and it's folder location on disk to bugsnag's ProjectPackages.
-	// This will ensure that Notify calls from bugsnagger.go will always share the same file name
-	// and will retain grouping across Shopify/goose dependency upgrades.
+type bugsnagOpts struct {
+	endpoints bugsnaggo.Endpoints
+}
+
+type BugsnaggerOption func(opts *bugsnagOpts)
+
+// WithEndpoints sets the endpoints for the bugsnag client
+func WithEndpoints(notifier bugsnaggo.Endpoints) BugsnaggerOption {
+	return func(opts *bugsnagOpts) {
+		opts.endpoints = notifier
+	}
+}
+
+// Setup initializes the bugsnag client with the given API key, commit, environment, and packages.
+// By default, it will use the endpoints for Shopify internal error analytics service.
+func (snagger *bugsnagger) Setup(
+	apiKey string,
+	commit string,
+	env string,
+	packages []string,
+	opts ...BugsnaggerOption,
+) {
+	// Add the bugsnag package and its folder location on disk to Bugsnag's ProjectPackages.
+	// This ensures Notify calls from bugsnagger.go always share the same file name
+	// and retain grouping across Shopify/goose dependency upgrades.
 	packages = append(packages, "main*", "github.com/Shopify/goose/bugsnag")
 	if _, file, _, ok := runtime.Caller(0); ok {
 		gooseMod := strings.TrimSuffix(file, "bugsnag/bugsnagger.go")
 		packages = append(packages, gooseMod+"*")
 	}
 
+	var bo = &bugsnagOpts{
+		endpoints: bugsnaggo.Endpoints{
+			Notify:   "https://error-analytics-production.shopifysvc.com",
+			Sessions: "https://error-analytics-sessions-production.shopifysvc.com",
+		},
+	}
+
+	for _, opt := range opts {
+		opt(bo)
+	}
+
 	bugsnaggo.OnBeforeNotify(httpRequestMiddleware)
 	bugsnaggo.Configure(bugsnaggo.Configuration{
 		APIKey:          apiKey,
@@ -228,6 +260,7 @@ func (snagger *bugsnagger) Setup(apiKey string, commit string, env string, packa
 		ReleaseStage:    env,
 		Synchronous:     true,
 		PanicHandler:    panicHandler,
+		Endpoints:       bo.endpoints,
 	})
 }