Reset all framebuffers before recreating swapchain

SharkFinPro · SharkFinPro · commit 7e966d497f50 · 2025-01-05T19:30:15.000-08:00
diff --git a/source/VulkanEngine.cpp b/source/VulkanEngine.cpp
@@ -374,6 +374,7 @@ void VulkanEngine::recreateSwapChain()
   logicalDevice->waitIdle();
 
   framebuffer.reset();
+  offscreenFramebuffer.reset();
   swapChain.reset();
 
   swapChain = std::make_shared<SwapChain>(physicalDevice, logicalDevice, window);
@@ -387,8 +388,6 @@ void VulkanEngine::recreateSwapChain()
       return;
     }
 
-    offscreenFramebuffer.reset();
-
     offscreenFramebuffer = std::make_shared<Framebuffer>(physicalDevice, logicalDevice, swapChain, commandPool,
                                                          renderPass, false, offscreenViewportExtent);
   }

Original file line number	Diff line number	Diff line change
`@@ -374,6 +374,7 @@ void VulkanEngine::recreateSwapChain()`
`374`	`374`	`logicalDevice->waitIdle();`
`375`	`375`
`376`	`376`	`framebuffer.reset();`
	`377`	`+ offscreenFramebuffer.reset();`
`377`	`378`	`swapChain.reset();`
`378`	`379`
`379`	`380`	`swapChain = std::make_shared<SwapChain>(physicalDevice, logicalDevice, window);`
`@@ -387,8 +388,6 @@ void VulkanEngine::recreateSwapChain()`
`387`	`388`	`return;`
`388`	`389`	`}`
`389`	`390`
`390`		`- offscreenFramebuffer.reset();`
`391`		`-`
`392`	`391`	`offscreenFramebuffer = std::make_shared<Framebuffer>(physicalDevice, logicalDevice, swapChain, commandPool,`
`393`	`392`	`renderPass, false, offscreenViewportExtent);`
`394`	`393`	`}`