Skip to content

Modal: closing on clicking inside itself after height change #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amankkg opened this issue Jun 7, 2018 · 5 comments
Open

Modal: closing on clicking inside itself after height change #2888

amankkg opened this issue Jun 7, 2018 · 5 comments
Labels

Comments

@amankkg
Copy link
Contributor

amankkg commented Jun 7, 2018

Bug Report

After adding more input fields in modal, clicking on plain link causes modal close. Seems like the height is changed and initial calculation of modal rectangle became outdated, so it behaves like on clicking outside of the modal.
Of course, closeOnDimmerClick={false} prop prevents this strange behavior.

Steps

  1. go to test case sandbox
  2. open modal by clicking Login (top left corner, also zoom out to see the links of modal)
  3. click Register link of the modal (the form just got bigger and Login click is out of initial dimension of the modal)
  4. click Login link of the modal

Expected Result

Modal is open

Actual Result

Modal is closed

Version

Semantic-UI React 0.81.1

Testcase

https://codesandbox.io/s/30n2v379r1 Semantic-UI CSS 2.2.13
upd. https://codesandbox.io/s/n70787j0yp Semantic-UI CSS 2.3.1

@layershifter
Copy link
Member

layershifter commented Jun 7, 2018

I've updated testcase to use SUI 2.3. However, I think that the problem is caused by removal of a click's target node.

@ghost ghost removed the triage label Jun 7, 2018
@layershifter layershifter changed the title Modal closing on clicking inside itself after height change Modal: closing on clicking inside itself after height change Jun 7, 2018
@stale
Copy link

stale bot commented Dec 5, 2018

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Dec 5, 2018
@amankkg
Copy link
Contributor Author

amankkg commented Dec 5, 2018

Didn't work with SUIR for a while. Not sure if it's still reproducible. Will take a look...

@stale stale bot removed the stale label Dec 5, 2018
@stale
Copy link

stale bot commented Jun 3, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale
Copy link

stale bot commented Nov 30, 2019

This issue will be closed due to lack of activity for 12 months. If you’d like this to be reopened, just leave a comment; we do monitor them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants