[ci] Fail workflow if Node image failed to build

Signed-off-by: Viet Nguyen Duc <[email protected]>

Author: VietND96

.github/workflows/release-firefox-versions.yml

@@ -119,13 +119,19 @@ jobs:
           retry_wait_seconds: 60
           command: |
             ./tests/build-backward-compatible/bootstrap.sh ${GRID_VERSION} ${BROWSER_VERSION} ${BROWSER_NAME} ${REUSE_BASE}
+            echo "FIREFOX_VERSION=${FIREFOX_VERSION}" >> $GITHUB_ENV
       - name: Build Hub image for testing
         if: env.REUSE_BASE == 'false'
         run: make hub
       - name: Test images with Grid core ${{ env.GRID_VERSION }} and ${{ env.BROWSER_NAME }} v${{ env.BROWSER_VERSION }}
-        run: |
-          make test_firefox
-          make test_firefox_standalone
+        uses: nick-invision/retry@master
+        with:
+          timeout_minutes: 20
+          max_attempts: 3
+          retry_wait_seconds: 60
+          command: |
+            FIREFOX_VERSION=${FIREFOX_VERSION} make test_firefox
+            FIREFOX_VERSION=${FIREFOX_VERSION} make test_firefox_standalone
       - name: Push images with Grid core ${{ env.GRID_VERSION }} and ${{ env.BROWSER_NAME }} v${{ env.BROWSER_VERSION }}
         if: env.PUSH_IMAGE == 'true'
         run: |

Makefile

@@ -664,7 +664,7 @@ test_edge_standalone:
   esac
 
 test_firefox_download_lang_packs:
-	FIREFOX_VERSION=$$(curl -sk https://product-details.mozilla.org/1.0/firefox_versions.json | jq -r '.LATEST_FIREFOX_VERSION') ; \
+	FIREFOX_VERSION=$(or $(FIREFOX_VERSION), $$(curl -sk https://product-details.mozilla.org/1.0/firefox_versions.json | jq -r '.LATEST_FIREFOX_VERSION')) ; \
 	./NodeFirefox/get_lang_package.sh $$FIREFOX_VERSION ./tests/target/firefox_lang_packs
 
 test_firefox: test_firefox_download_lang_packs

NodeFirefox/Dockerfile

@@ -30,7 +30,10 @@ RUN apt-get update -qqy && \
         ln -fs $(which firefox$FIREFOX_VERSION) /usr/bin/firefox ; \
       fi ; \
     else \
-      FIREFOX_DOWNLOAD_URL="https://download-installer.cdn.mozilla.net/pub/firefox/releases/$FIREFOX_VERSION/linux-x86_64/en-US/firefox-$FIREFOX_VERSION.deb" ; \
+      FIREFOX_DOWNLOAD_URL="https://download-installer.cdn.mozilla.net/pub/firefox/releases/$FIREFOX_VERSION/linux-x86_64/en-US/firefox-$FIREFOX_VERSION.deb" \
+      && if [ "404" = "$(curl -s -o /dev/null -w "%{http_code}" $FIREFOX_DOWNLOAD_URL)" ]; then \
+        FIREFOX_DOWNLOAD_URL="https://download-installer.cdn.mozilla.net/pub/firefox/releases/$FIREFOX_VERSION/linux-x86_64/en-US/firefox-$FIREFOX_VERSION.tar.bz2" ; \
+      fi ; \
     fi \
   else \
     if [ ${FIREFOX_VERSION} = "latest" ] && [ ${FIREFOX_DOWNLOAD_URL} = "" ]; then \
@@ -52,7 +55,7 @@ RUN apt-get update -qqy && \
     /opt/bin/install-firefox-package.sh "${FIREFOX_DOWNLOAD_URL}" "${FIREFOX_VERSION}" ; \
   fi \
   # Download the language pack for Firefox
-  && /opt/bin/get_lang_package.sh \
+  && /opt/bin/get_lang_package.sh ${FIREFOX_VERSION} \
   # Do one more upgrade to fix possible CVEs from Firefox dependencies
   && apt-get update -qqy \
   && apt-get upgrade -yq \

NodeFirefox/get_lang_package.sh

@@ -13,6 +13,10 @@ trap on_exit EXIT ERR
 VERSION=${1:-$(curl -sk https://product-details.mozilla.org/1.0/firefox_versions.json | jq -r '.LATEST_FIREFOX_VERSION')}
 TARGET_DIR="${2:-$(dirname $(readlink -f $(which firefox)))/distribution/extensions}"
 BASE_URL="https://ftp.mozilla.org/pub/firefox/releases/$VERSION/linux-x86_64/xpi/"
+if [ "404" = "$(curl -s -o /dev/null -w "%{http_code}" ${BASE_URL})" ]; then
+  VERSION="$(curl -sk https://product-details.mozilla.org/1.0/firefox_versions.json | jq -r '.LATEST_FIREFOX_VERSION')"
+  BASE_URL="https://ftp.mozilla.org/pub/firefox/releases/$VERSION/linux-x86_64/xpi/"
+fi
 
 # Create target directory if it doesn't exist
 mkdir -p "${TARGET_DIR}"

tests/build-backward-compatible/bootstrap.sh

@@ -31,9 +31,14 @@ for CDP_VERSION in "${VERSION_LIST[@]}"; do
     if [ -n "${FIREFOX_VERSION}" ]; then
       BUILD_ARGS="--build-arg FIREFOX_VERSION=${FIREFOX_VERSION} --build-arg FIREFOX_DOWNLOAD_URL=${FIREFOX_DOWNLOAD_URL}"
       if [ "${REUSE_BASE}" = "true" ]; then
-        BUILD_ARGS="${BUILD_ARGS}" make firefox_only standalone_firefox_only
+        BUILD_ARGS="${BUILD_ARGS}" PLATFORMS=${PLATFORMS} make firefox_only
+        if [ $? -ne 0 ]; then
+          echo "Error building Node image"
+          exit 1
+        fi
+        BUILD_ARGS="${BUILD_ARGS}" PLATFORMS=${PLATFORMS} make standalone_firefox_only
       else
-        BUILD_ARGS="${BUILD_ARGS}" make standalone_firefox
+        BUILD_ARGS="${BUILD_ARGS}" PLATFORMS=${PLATFORMS} make standalone_firefox
       fi
     else
       echo "Firefox version not found in matrix for input ${CDP_VERSION}"
@@ -44,7 +49,12 @@ for CDP_VERSION in "${VERSION_LIST[@]}"; do
     if [ -n "${EDGE_VERSION}" ]; then
       BUILD_ARGS="--build-arg EDGE_VERSION=${EDGE_VERSION}"
       if [ "${REUSE_BASE}" = "true" ]; then
-        BUILD_ARGS="${BUILD_ARGS}" make edge_only standalone_edge_only
+        BUILD_ARGS="${BUILD_ARGS}" make edge_only
+        if [ $? -ne 0 ]; then
+          echo "Error building Node image"
+          exit 1
+        fi
+        BUILD_ARGS="${BUILD_ARGS}" make standalone_edge_only
       else
         BUILD_ARGS="${BUILD_ARGS}" make standalone_edge
       fi
@@ -57,7 +67,12 @@ for CDP_VERSION in "${VERSION_LIST[@]}"; do
     if [ -n "${CHROME_VERSION}" ]; then
       BUILD_ARGS="--build-arg CHROME_VERSION=${CHROME_VERSION}"
       if [ "${REUSE_BASE}" = "true" ]; then
-        BUILD_ARGS="${BUILD_ARGS}" make chrome_only standalone_chrome_only
+        BUILD_ARGS="${BUILD_ARGS}" make chrome_only
+        if [ $? -ne 0 ]; then
+          echo "Error building Node image"
+          exit 1
+        fi
+        BUILD_ARGS="${BUILD_ARGS}" make standalone_chrome_only
       else
         BUILD_ARGS="${BUILD_ARGS}" make standalone_chrome
       fi

tests/build-backward-compatible/builder.py

@@ -50,6 +50,8 @@ def recursive_merge(dict1, dict2):
         if "FIREFOX_PLATFORMS" in matrix["CDP"][cdp_version]:
           FIREFOX_PLATFORMS = matrix["CDP"][cdp_version]["FIREFOX_PLATFORMS"]
           f.write(f"PLATFORMS={FIREFOX_PLATFORMS}\n")
+        else:
+          f.write(f"PLATFORMS=linux/amd64\n")
       if browser_name == "edge" or browser_name == "all":
         EDGE_VERSION = matrix["CDP"][cdp_version]["EDGE_VERSION"]
         f.write(f"EDGE_VERSION={EDGE_VERSION}\n")