bug: Fixing memory allocation error in openSeaChest_Raw

Fixing a bug where memory will not be allocated properly for issuing a raw command.
Part of the issue is that the device's block size is not populated and part of the issue is unclear command line options and option parsing.
I resolved the option parsing and help text for the options in this commit.

Signed-off-by: Tyler Erickson <[email protected]>

Author: vonericsen

src/openseachest_util_options.c

@@ -5345,7 +5345,8 @@ void print_Raw_Data_Length_Help(bool shortHelp)
         printf("\t\tThe following post fixes are allowed for\n");
         printf("\t\tspecifying a transfer length:\n");
         printf("\t\t\tBLOCKS - used to specify a transfer length\n");
-        printf("\t\t\t\tin device logical blocks. (Preferred)\n");
+        printf("\t\t\t\tin device logical blocks.\n");
+        printf("\t\t\tB - length in bytes (val * 1) (default if no unit given)\n");
         printf("\t\t\tKB - length in kilobytes (val * 1000)\n");
         printf("\t\t\tKiB - length in kibibytes (val * 1024)\n");
         printf("\t\t\tMB - length in megabytes (val * 1000000)\n");
@@ -5416,7 +5417,8 @@ void print_Raw_Input_File_Offset_Help(bool shortHelp)
         printf("\t\tThe following post fixes are allowed for\n");
         printf("\t\tspecifying a transfer length:\n");
         printf("\t\t\tBLOCKS - used to specify an offset length\n");
-        printf("\t\t\t\tin device logical blocks. (Preferred)\n");
+        printf("\t\t\t\tin device logical blocks.\n");
+        printf("\t\t\tB - length in bytes (val * 1) (Default if no unit given)\n");
         printf("\t\t\tKB - length in kilobytes (val * 1000)\n");
         printf("\t\t\tKiB - length in kibibytes (val * 1024)\n");
         printf("\t\t\tMB - length in megabytes (val * 1000000)\n");

subprojects/opensea-operations

@@ -29,7 +29,7 @@
 //  Global Variables  //
 ////////////////////////
 const char* util_name    = "openSeaChest_Raw";
-const char* buildVersion = "0.9.0";
+const char* buildVersion = "0.9.1";
 
 ////////////////////////////
 //  functions to declare  //
@@ -550,14 +550,14 @@ int main(int argc, char* argv[])
                     uint32_t multiplier = UINT32_C(1);
                     if (unit)
                     {
-                        if (strcmp(unit, "") == 0)
+                        if (strcmp(unit, "BLOCKS") == 0 || strcmp(unit, "SECTORS") == 0)
                         {
+                            // they specified blocks. For log transfers this means a number of 512B sectors
                             RAW_DATA_LEN_ADJUST_BY_BLOCKS_FLAG = true;
                         }
-                        else if (strcmp(unit, "BLOCKS") == 0 || strcmp(unit, "SECTORS") == 0)
+                        else if (strcmp(unit, "B") == 0 || strcmp(unit, "") == 0)
                         {
-                            // they specified blocks. For log transfers this means a number of 512B sectors
-                            multiplier = LEGACY_DRIVE_SEC_SIZE;
+                            multiplier = UINT32_C(1);
                         }
                         else if (strcmp(unit, "KB") == 0)
                         {
@@ -590,6 +590,7 @@ int main(int argc, char* argv[])
                         }
                     }
                     RAW_DATA_LEN_FLAG *= multiplier;
+                    printf("Raw data len = %" PRIu32 "\n", RAW_DATA_LEN_FLAG);
                 }
                 else
                 {
@@ -1316,7 +1317,7 @@ int main(int argc, char* argv[])
                             dataBuffer = M_REINTERPRET_CAST(
                                 uint8_t*, safe_calloc_aligned(allocatedDataLength, sizeof(uint8_t),
                                                               deviceList[deviceIter].os_info.minimumAlignment));
-                            if (!dataBuffer)
+                            if (dataBuffer == M_NULLPTR)
                             {
                                 if (VERBOSITY_QUIET < toolVerbosity)
                                 {
@@ -1620,9 +1621,7 @@ int main(int argc, char* argv[])
                 exitCode = UTIL_EXIT_ERROR_IN_COMMAND_LINE;
             }
         }
-
-        // perform some sort of validation to see that we have some command to send...then build it and send it.
-        if (RAW_TFR_SIZE_FLAG != 0 && RAW_TFR_PROTOCOL != -1 && RAW_TFR_XFER_LENGTH_LOCATION != -1 &&
+        else if (RAW_TFR_SIZE_FLAG != 0 && RAW_TFR_PROTOCOL != -1 && RAW_TFR_XFER_LENGTH_LOCATION != -1 &&
             RAW_TFR_BYTE_BLOCK != -1)
         {
             ataPassthroughCommand passthroughCommand;