dvc: use dvc.org url for download urls #6848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only support download URLs from dvc.org. The S3 URL is a result of us using s3 bucket for hosting packages, and we're in the process of transitioning to Cloudflare R2.
skshetry
changed the title
|
All changes look good. Wait for review from human collaborators. dvc
|
|
Hi, @HUMORCE, is it Scoop’s policy to always use the original source URL? My intention with this PR was to use dvc.org/downloads, since it’s likely to be more stable over time (since that's what we use in the website). What you’ve merged is something I did not intend. |
|
It can also be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only support download URLs from dvc.org. The S3 URL is a result of us using s3 bucket for hosting packages, and we're in the process of transitioning to Cloudflare R2.
(although those are internals that Scoop should not rely on).
Related: