fix: call destructor of weak pointer explicitly

Signed-off-by: Hosung Kim [email protected]

Author: hs0225

deps/node/lib/internal/fs/promises.js

@@ -75,16 +75,16 @@ const kCloseResolve = Symbol('kCloseResolve');
 const kCloseReject = Symbol('kCloseReject');
 
 const { kUsePromises } = binding;
-const {
-  JSTransferable, kDeserialize, kTransfer, kTransferList
-} = require('internal/worker/js_transferable');
+// const {
+//   JSTransferable, kDeserialize, kTransfer, kTransferList
+// } = require('internal/worker/js_transferable');
 
 const getDirectoryEntriesPromise = promisify(getDirents);
 const validateRmOptionsPromise = promisify(validateRmOptions);
 
-class FileHandle extends JSTransferable {
+class FileHandle { // extends JSTransferable @lwnode
   constructor(filehandle) {
-    super();
+    // super(); // @lwnode
     this[kHandle] = filehandle;
     this[kFd] = filehandle ? filehandle.fd : -1;
 
@@ -185,32 +185,33 @@ class FileHandle extends JSTransferable {
     return this[kClosePromise];
   }
 
-  [kTransfer]() {
-    if (this[kClosePromise] || this[kRefs] > 1) {
-      const DOMException = internalBinding('messaging').DOMException;
-      throw new DOMException('Cannot transfer FileHandle while in use',
-                             'DataCloneError');
-    }
-
-    const handle = this[kHandle];
-    this[kFd] = -1;
-    this[kHandle] = null;
-    this[kRefs] = 0;
-
-    return {
-      data: { handle },
-      deserializeInfo: 'internal/fs/promises:FileHandle'
-    };
-  }
-
-  [kTransferList]() {
-    return [ this[kHandle] ];
-  }
-
-  [kDeserialize]({ handle }) {
-    this[kHandle] = handle;
-    this[kFd] = handle.fd;
-  }
+  // @lwnode
+  // [kTransfer]() {
+  //   if (this[kClosePromise] || this[kRefs] > 1) {
+  //     const DOMException = internalBinding('messaging').DOMException;
+  //     throw new DOMException('Cannot transfer FileHandle while in use',
+  //                            'DataCloneError');
+  //   }
+
+  //   const handle = this[kHandle];
+  //   this[kFd] = -1;
+  //   this[kHandle] = null;
+  //   this[kRefs] = 0;
+
+  //   return {
+  //     data: { handle },
+  //     deserializeInfo: 'internal/fs/promises:FileHandle'
+  //   };
+  // }
+
+  // [kTransferList]() {
+  //   return [ this[kHandle] ];
+  // }
+
+  // [kDeserialize]({ handle }) {
+  //   this[kHandle] = handle;
+  //   this[kFd] = handle.fd;
+  // }
 }
 
 async function fsCall(fn, handle, ...args) {

deps/node/src/node_crypto.cc

@@ -1383,7 +1383,8 @@ void SecureContext::SetSessionTimeout(const FunctionCallbackInfo<Value>& args) {
 void SecureContext::Close(const FunctionCallbackInfo<Value>& args) {
   SecureContext* sc;
   ASSIGN_OR_RETURN_UNWRAP(&sc, args.Holder());
-  sc->Reset();
+  // sc->Reset(); // @lwnode
+  delete sc; // @lwnode
 }
 
 

deps/node/src/node_file.cc

@@ -368,6 +368,8 @@ MaybeLocal<Promise> FileHandle::ClosePromise() {
       } else {
         close->Resolve();
       }
+
+      delete close->file_handle(); // @lwnode
     }};
     int ret = req->Dispatch(uv_fs_close, fd_, AfterClose);
     if (ret < 0) {

deps/node/test/skip_tests.txt

@@ -212,3 +212,5 @@ test/parallel/test-zlib-invalid-input-memory.js
 test/parallel/test-zlib-unused-weak.js
 test/parallel/test-repl-syntax-error-stack.js # timeout error occurs when debugger feature has been updated
 test/parallel/test-promises-unhandled-rejections.js # crash error occurs when debugger feature has been updated
+test/parallel/test-worker-message-port-transfer-fake-js-transferable.js # disable fs message port transfer
+test/parallel/test-worker-message-port-transfer-fake-js-transferable-internal.js # disable fs message port transfer