feat: add gc_free_space_divisor config

Signed-off-by: Hosung Kim [email protected]

Author: hs0225

deps/node/src/lwnode/lwnode-public.cc

@@ -239,6 +239,11 @@ bool Runtime::Configuration::Set(const std::string& key, int value) {
                     value);
     LWNode::GlobalConfiguration::GetInstance().set_gc_interval(value);
     return true;
+  } else if (key == "gc_free_space_divisor") {
+    LWNODE_DEV_LOGF(
+        "[Runtime::Configuration::Set] GC free space divisor set to %d", value);
+    LWNode::GlobalConfiguration::GetInstance().set_gc_free_space_divisor(value);
+    return true;
   }
   return false;
 }

src/api/engine.cc

@@ -21,6 +21,7 @@
 
 #include "api/global.h"
 #include "handle.h"
+#include "lwnode/global-configuration.h"
 #include "lwnode/lwnode-loader.h"
 #include "utils/misc.h"
 #include "utils/string-util.h"
@@ -351,7 +352,7 @@ bool Engine::Dispose() {
   return true;
 }
 
-#define GC_FREE_SPACE_DIVISOR 4
+#define DEFAULT_GC_FREE_SPACE_DIVISOR 4
 
 void Engine::initialize() {
 #ifndef NDEBUG
@@ -367,7 +368,13 @@ void Engine::initialize() {
 #endif
 
   Globals::initialize(Platform::GetInstance());
-  Memory::setGCFrequency(GC_FREE_SPACE_DIVISOR);
+  int gcFreeSpaceDivisor =
+      LWNode::GlobalConfiguration::GetInstance().gc_free_space_divisor();
+  if (gcFreeSpaceDivisor < 0) {
+    gcFreeSpaceDivisor = DEFAULT_GC_FREE_SPACE_DIVISOR;
+  }
+
+  Memory::setGCFrequency(gcFreeSpaceDivisor);
   gcHeap_.reset(GCHeap::create());
 
   if (Global::flags()->isOn(Flag::Type::TraceGC)) {

src/lwnode/global-configuration.h

@@ -31,11 +31,17 @@ class GlobalConfiguration {
   void set_gc_interval(int interval) { gc_interval_ = interval; }
   int gc_interval() { return gc_interval_; }
 
+  void set_gc_free_space_divisor(int divisor) {
+    gc_free_space_divisor_ = divisor;
+  }
+  int gc_free_space_divisor() { return gc_free_space_divisor_; }
+
  private:
   GlobalConfiguration() = default;
   ~GlobalConfiguration() = default;
 
   int gc_interval_ = -1;  // TODO: change optional type
+  int gc_free_space_divisor_ = -1;
 };
 
 }  // namespace LWNode

test/embedding/example.cc

@@ -16,6 +16,10 @@ int main(int argc, char* argv[]) {
   if (!configuration.Set("gc_interval", 10000)) {
     std::cerr << "Failed to set gc_interval" << std::endl;
   }
+  if (!configuration.Set("gc_free_space_divisor", 10)) {
+    std::cerr << "Failed to set gc_free_space_divisor" << std::endl;
+  }
+
   auto runtime = std::make_shared<lwnode::Runtime>(std::move(configuration));
 
   std::promise<void> promise;