fix: remove hidden class chain

Signed-off-by: Hosung Kim [email protected]

Author: hs0225

include/lwnode/lwnode-version.h

@@ -18,5 +18,5 @@
 
  #define LWNODE_VERSION_MAJOR 1
  #define LWNODE_VERSION_MINOR 0
- #define LWNODE_VERSION_PATCH 3
- #define LWNODE_VERSION_TAG "v1.0.3"
+ #define LWNODE_VERSION_PATCH 4
+ #define LWNODE_VERSION_TAG "v1.0.4"

src/api/es-helper.cc

@@ -984,6 +984,7 @@ ErrorObjectRef* ExceptionHelper::createErrorObject(ContextRef* context,
          ErrorObjectRef::Code code,
          StringRef* errorMessage) -> ValueRef* {
         auto errorObject = ErrorObjectRef::create(state, code, errorMessage);
+        errorObject->removeFromHiddenClassChain();
         ExceptionHelper::addStackPropertyCallback(state, errorObject);
         return errorObject;
       },

src/api/isolate.cc

@@ -93,6 +93,9 @@ Escargot::ValueRef* Isolate::pending_exception() {
 void Isolate::set_pending_exception(Escargot::ValueRef* exception_obj) {
   LWNODE_CALL_TRACE_ID(TRYCATCH);
   LWNODE_CHECK_NOT_NULL(exception_obj);
+  if (exception_obj->isObject()) {
+    exception_obj->asObject()->removeFromHiddenClassChain();
+  }
   pending_exception_ = exception_obj;
 }
 

src/api/stack-trace.cc

@@ -38,6 +38,11 @@ class PrepareStackTraceScope {
   IsolateWrap* isolate_;
 };
 
+StackTrace::StackTrace(ExecutionStateRef* state, ObjectRef* error)
+    : state_(state), error_(error) {
+  error_->removeFromHiddenClassChain();
+}
+
 bool StackTrace::getStackTraceLimit(ExecutionStateRef* state,
                                     double& stackTraceLimit) {
   auto errorObject = state->context()->globalObject()->get(
@@ -159,7 +164,9 @@ ValueRef* StackTrace::captureStackTraceCallback(ExecutionStateRef* state,
   // FIXME: it seems there are some cases where we need to freeze the
   // stack string here. Investigate further
   StackTrace stackTrace(state, exceptionObject);
-  stackTrace.addStackProperty(ArrayObjectRef::create(state, stackTraceVector));
+  auto arrayObject = ArrayObjectRef::create(state, stackTraceVector);
+  arrayObject->removeFromHiddenClassChain();
+  stackTrace.addStackProperty(arrayObject);
 
   return ValueRef::createUndefined();
 }
@@ -182,7 +189,9 @@ ValueRef* StackTrace::createCaptureStackTrace(
       true,
       false);
 
-  return FunctionObjectRef::create(state, info);
+  auto captureStackTrace = FunctionObjectRef::create(state, info);
+  captureStackTrace->removeFromHiddenClassChain();
+  return captureStackTrace;
 }
 
 ValueRef* StackTrace::createPrepareStackTrace(
@@ -194,7 +203,9 @@ ValueRef* StackTrace::createPrepareStackTrace(
       true,
       false);
 
-  return FunctionObjectRef::create(state, info);
+  auto prepareStackTrace = FunctionObjectRef::create(state, info);
+  prepareStackTrace->removeFromHiddenClassChain();
+  return prepareStackTrace;
 }
 
 ValueRef* StackTrace::prepareStackTraceCallback(ExecutionStateRef* state,
@@ -277,7 +288,9 @@ ArrayObjectRef* StackTrace::genCallSites(
         callSite->instantiate(state_->context(), stackTraceData[i]));
   }
 
-  return ArrayObjectRef::create(state_, stackTraceVector);
+  auto stackTrace = ArrayObjectRef::create(state_, stackTraceVector);
+  stackTrace->removeFromHiddenClassChain();
+  return stackTrace;
 }
 
 CallSite::CallSite(ContextRef* context) : context_(context) {
@@ -410,7 +423,7 @@ void CallSite::setCallSitePrototype(
       [](ExecutionStateRef* state,
          const std::string* name,
          Escargot::FunctionObjectRef::NativeFunctionPointer fn) -> ValueRef* {
-        return FunctionObjectRef::create(
+        auto callSite = FunctionObjectRef::create(
             state,
             FunctionObjectRef::NativeFunctionInfo(
                 AtomicStringRef::create(
@@ -419,6 +432,8 @@ void CallSite::setCallSitePrototype(
                 0,
                 true,
                 false));
+        callSite->removeFromHiddenClassChain();
+        return callSite;
       },
       &name,
       fn);

src/api/stack-trace.h

@@ -55,8 +55,7 @@ class StackTrace {
     ValueRef* stackValue_ = nullptr;
   };
 
-  StackTrace(ExecutionStateRef* state, ObjectRef* error)
-      : state_(state), error_(error) {}
+  StackTrace(ExecutionStateRef* state, ObjectRef* error);
 
   static bool checkFilter(ValueRef* filter,
                           const Evaluator::StackTraceData& traceData);

src/lwnode/lwnode.cc

@@ -172,6 +172,7 @@ static ValueRef* getGCMemoryStats(ExecutionStateRef* state,
                                   bool isConstructCall) {
   auto context = state->context();
   auto object = ObjectRefHelper::create(context);
+  object->removeFromHiddenClassChain();
 
   // GC_heapsize - GC_unmapped_bytes
   ObjectRefHelper::setProperty(context,

src/lwnode/nd-mod-message-port.cc

@@ -79,6 +79,7 @@ static ObjectRef* InstantiateMessageEvent(ExecutionStateRef* state,
 
   // Create a new MessageEvent
   auto option = ObjectRef::create(state);
+  option->removeFromHiddenClassChain();
 
   struct MessageEventExtraData : public gc_cleanup {
     std::shared_ptr<MessageEventSync::HandleData> handle;