Skip to content

[OneExplorer] Support viewer for tflite/onnx #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dayo09 opened this issue Aug 25, 2022 · 3 comments
Open

[OneExplorer] Support viewer for tflite/onnx #1241

dayo09 opened this issue Aug 25, 2022 · 3 comments

Comments

@dayo09
Copy link
Contributor

dayo09 commented Aug 25, 2022

What?

Let's support viewer for tflite/onnx.
Logically, netron support boths, but it seems that the current circle-dedicated viewer (CircleViewer) is not working with tflite/onnx files.

The error message showed up when I tried to open a tflite file with circle viewer.
image

/cc @lemmaa @seanshpark

@dayo09
Copy link
Contributor Author

dayo09 commented Aug 25, 2022

@seanshpark AFAIK, the circle-netron supports tflite/onnx files. However, it seems that our CircleViewer doesn't support them. Do you think that it's possible to support tflite/onnx files, too?

@seanshpark
Copy link
Contributor

Do you think that it's possible to support tflite/onnx files, too?

Current implementation: NO

How netron supports multiple formats?

  • it dynamically loads file loader .js files

How current circle viewer control works?

  • static loading of circle file loader codes and some fixed codes based on handing circle files
  • has some modification for partition editing that may disturb loading tflite/onnx

So, IMHO, how to support tflite/onnx files?

  • for simplicity, add another module for tflite and onnx both or two modules for each

@dayo09
Copy link
Contributor Author

dayo09 commented Aug 29, 2022

for simplicity, add another module for tflite and onnx both or two modules for each

Oh, therefore we need to port other modules to support tflite/onnx viewers... :-D

/cc @Samsung/one-vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants