Skip to content

[Profile] Support JsonTracer one-click opening #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dayo09 opened this issue Aug 3, 2022 · 2 comments
Closed

[Profile] Support JsonTracer one-click opening #1135

dayo09 opened this issue Aug 3, 2022 · 2 comments

Comments

@dayo09
Copy link
Contributor

dayo09 commented Aug 3, 2022

What?

Let's enable opening 'JsonTracer' by clicking trace.json file.
Currently, 'JsonTracer' opens only a panel and users should manually 'load' file with file selection window.

Why?

To support 'open with view' for chrome trace files in OneExplorer.
@dayo09
Copy link
Contributor Author

dayo09 commented Aug 3, 2022

For this, we need to introduce ChromeTracerViewer custom text editor provider... It takes a bit of works

@dayo09
Copy link
Contributor Author

dayo09 commented Aug 4, 2022

Study

  1. CustomEditorProvider vs CustomTextEditorProvider : which one to use?
  • CustomEditorProvider for binary files, CustomTextEditorProvider for text based files (json)
  • Let's use CustomTextEditorProvider

@dayo09 dayo09 mentioned this issue Aug 4, 2022
Closed
@dayo09 dayo09 closed this as completed Aug 5, 2022
@llFreetimell llFreetimell mentioned this issue Aug 5, 2022
Merged
@dayo09 dayo09 mentioned this issue Aug 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dayo09