Skip to content

Make newNotes state consistent in RecruitmentInterviewNotesForm #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Erichseen opened this issue Mar 20, 2025 · 0 comments · May be fixed by #1854
Open

Make newNotes state consistent in RecruitmentInterviewNotesForm #1767

Erichseen opened this issue Mar 20, 2025 · 0 comments · May be fixed by #1854
Labels
difficulty: advanced Difficult and time consuming task. frontend Task related to frontend. priority: high recruitment Task related to the recruitment system refactor Clean up code without changing functionality

Comments

@Erichseen
Copy link
Contributor

Fil:RecruitmentInterviewNotesForm.tsx

KODE:
"
field.onBlur(); // Call the default onBlur handler from react-hook-form|
handleNotesChange(newNotes.target.value); // Call your custom function on blur
"

Mathias-a:
"
Dette er nok ikke helt din skyld, men tror jeg hadde foretrukket (om mulig) at vi ikke forholdt oss til "newNotes", men heller bare forholdt oss til verdien til feltet i formet. Vet ikke om det funker med conditional rendering?
"

Suggestion: Use the inherit state from zod in the form. Zod keeps track of the value in the field, should be able to use this

@nemisis84 nemisis84 self-assigned this Apr 1, 2025
@nemisis84 nemisis84 added frontend Task related to frontend. difficulty: advanced Difficult and time consuming task. priority: high recruitment Task related to the recruitment system refactor Clean up code without changing functionality labels Apr 1, 2025
@nemisis84 nemisis84 linked a pull request Apr 1, 2025 that will close this issue
@nemisis84 nemisis84 removed their assignment Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: advanced Difficult and time consuming task. frontend Task related to frontend. priority: high recruitment Task related to the recruitment system refactor Clean up code without changing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants